Increase the visibility of the git_data_dir warning before we remove (!1937) · Merge requests · GitLab.org / omnibus-gitlab · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

DJ Mountney requested to merge increase-git-data-dir-warning into master Sep 16, 2017

Increase the visibility of the git_data_dir warning before we remove

Highlight the warning in yellow
Print to stdout in additon to the log
Include the updated config in the output, to make it easy to update
Sleep for 5 seconds, to increase the possibility the warning will be seen

Because this warning is thrown during parsing, it will show very close to the top of the reconfigure run.

Fixes: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2757

Will be improved by https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2533

And I think we should implement this when we go to properly remove the setting in GitLab 11: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2782

cc\ @stanhu @joshlambert