Increase the visibility of the git_data_dir warning before we remove

Increase the visibility of the git_data_dir warning before we remove

• Highlight the warning in yellow
• Print to stdout in additon to the log
• Include the updated config in the output, to make it easy to update
• Sleep for 5 seconds, to increase the possibility the warning will be seen

Because this warning is thrown during parsing, it will show very close to the top of the reconfigure run.

Fixes: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2757

Will be improved by https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2533

And I think we should implement this when we go to properly remove the setting in GitLab 11: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2782

cc\ @stanhu @joshlambert

mentioned in issue #2757 (closed)

I can't review the code, but I like the improvements!

Other than a slight nitpick, this looks good to me. I'll approve the MR as I don't think we need to pass it back and forth for string formatting.

approved this merge request

assigned to @twk3

added 1 commit

• 604f0b28 - Update warning message doce formatting to be multiline

Compare with previous version

resolved all discussions

mentioned in commit 98b7b998

merged

Picked into 10-0-stable and 10-0-stable-ee, will be ready for 10.0 RC5 EE

removed Pick into Stable label

mentioned in commit 998173b5

mentioned in commit f65a1743