Ignore errors on pgb-notify failure

Closes #2796

unmarked as a Work In Progress

changed title from WIP: Resolve "Ensure consul runs before pgbouncer" to Ignore errors on pgb-notify failure

added Pick into Stable label

assigned to @twk3

I'm not 100% sure this is the right way.

In a non-HA setup, this shouldn't error.

In an HA setup, if consul or the database isn't ready yet, this will error. I could move the call to consul::enable in gitlab-ee::default earlier, but there still isn't a guarantee really that everything will be ok.

I'm not keen on conditionally ignoring the error, but I haven't ruled it out.

@ibaum Did you forget to push the branch? This MR is empty.

assigned to @ibaum

added 1 commit

• 47a74da1 - Update pgbouncer notification to not stop on failure

Compare with previous version

@marin Sigh, yes I did.

assigned to @twk3

@ibaum instead of ignoring the failure, could we instead use an only_if call that checks that the database is ready?

@twk3 Yes we could, thanks. I like that approach better.

added 1 commit

• be80615f - Update to pgb-notify behavior

Compare with previous version

@ibaum I notice, unlike some of our other services, we aren't explicitly calling start on pgbouncer after we setup the runit service. Is this intentional? Would starting it first have helped to solve this problem as well?

added 1 commit

• 0d24e417 - Add call to start pgboucner on configuration

Compare with previous version

assigned to @ibaum

added 1 commit

• b52f0a37 - Fix error in pgbouncer recipe

Compare with previous version

assigned to @twk3

resolved all discussions

assigned to @marin

approved this merge request

added 1 commit

• 49bfda11 - 1 commit from branch master

Compare with previous version

Wow, this MR is in a very weird state. MR is merged so I don't know why this is showing an empty state. /cc @smcgivern

@marin yep, I think this is https://gitlab.com/gitlab-org/gitlab-ce/issues/37775 / https://gitlab.com/gitlab-org/gitlab-ce/issues/32812#note_39580785.