Skip to content

Improve handling of environment variables for gitlab-rails

username-removed-5302 requested to merge jacobvosmaer/omnibus-gitlab:improve_env into master

This MR fixes two things related to ENV variables for Rails processes.

  • proper deletion of ENV variables when they get removed from gitlab.rb
  • sharing the same ENV for Unicorn, Sidekiq, gitlab-rake and gitlab-rails

In addition this removes some dynamic checks (who is the git user) from gitlab-rake and gitlab-rails in favor of a static file generated by gitlab-ctl reconfigure.

Merge request reports