Skip to content
Snippets Groups Projects

External url variable should match

Closed Sid Sijbrandij requested to merge external-url-variable-should-match into master

This is to illustrate a fix for https://gitlab.com/gitlab-org/omnibus-gitlab/commit/0402cdc9015bfd9bd516b021a2fff63ac99ebea1

In the old situation:

  1. The variable contained the wrong thing (named external url, contained an FQDN)
  2. The default value would lead to http begin added again

THIS MR IS NOT TESTED, just an illustration of the proposed fix

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading