Assets directory

Closes #492 (closed)

Set open permissions to all files in assets directory while disallowing the deletion using the sticky bit. This will allow running the gitlab-rake assets:precompile task.

@jacobvosmaer I need your input on this. I don't see a security downside to this however, setting open permissions is always a code smell.

No way are we setting 777 permissions here. These files should be read-only.

Apart from the no way argument, I would like to know why would it be a problem given that the owner is still root and you cannot delete files if you don't own them. Is there another option for this?

Any system user could insert malicious javascript because they get write access. That is a problem, no?

Status changed to closed

Yup

Thanks for calling me out on my emotional reaction to mode 777 :)