Skip to content

Updated the openshift template with feedback from openshift

DJ Mountney requested to merge openshift-reviewed-updates into master

Updated the openshift template with fixes to the app name, and the addition of an optional root password parameter.

Convo from openshift-gitlab slack channel:

jmorales [5:59 AM]  
@dmountney In latest release template, following lines are not correct (311, 317,  432, 438, 571, 584, 597). All these lines should read:    "app":"${APPLICATION_NAME}"

[6:00]  
@dmountney also, you should not set a default value for APPLICATION_HOSTNAME, so line 26 should be empty

[6:01]  
@dmountney and would be cool if you would parameterize setting root password, so in the logic to the gitlab, if there's a variable "ROOT_PASSWORD" (empty by default) set it, so that gitlab can be used straight away. This way, one can automate provisioning of gitlab via API commands

Merge request reports