Skip to content
Snippets Groups Projects

Automatically add version.gitlab.com entry on release

Closed Robert Speicher requested to merge rs-version-api into master

Closes #15 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 2 require 'faraday'
    3
    4 require_relative 'version'
    5
    6 Dotenv.load
    7
    8 class VersionClient
    9 # Create a version entry on version.gitlab.com
    10 #
    11 # version - Version object or String
    12 #
    13 # Returns a Faraday::Response object
    14 def self.create_version(version)
    15 params = { version: version.to_s }.to_json
    16
    17 connection.post('versions', params)
  • This is nice, I had a few questions, though.

    Also, is it ok to create the version on version.gitlab.com before the actual packages are built?

  • Also, is it ok to create the version on version.gitlab.com before the actual packages are built?

    Good point. Hmm. We'd have to do it in the .gitlab-ci.yml of Omnibus as a final step after building and that wouldn't be as clean. What do you think, @marin?

    Edited by Robert Speicher
  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • b450dcdf - Be pickier about when we add a version.gitlab.com entry
  • Robert Speicher Added 1 commit:

    Added 1 commit:

    • 122a1189 - Add docs for version.gitlab.com creation
  • Reassigned to @rymai

  • @rspeicher @rymai We can do it in omnibus-gitlab build. It can be an additional step and we can try using the CI variables for the token, would be a nice thing to use.

  • Thanks @marin!

    @rspeicher Let's do this in Omnibus in a new CI step then, as we do for CE: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.gitlab-ci.yml#L309-318

  • mentioned in merge request omnibus-gitlab!760 (merged)

  • Closing in favor of doing this in Omnibus.

  • Robert Speicher Status changed to closed

    Status changed to closed

  • Please register or sign in to reply
    Loading