autocomplete/command history behavior on command line is overaggressive and buggy w/regard to arrow keys
- iTerm2 version: 3.1.2
- OS version: macOS 10.12.6
- Attach ~/Library/Preferences/com.googlecode.iterm2.plist here (drag-drop from finder into this window)
- Attach a debug log, if possible. Instructions at https://iterm2.com/debuglog
Not attached yet, but if you decide you want one, I'll send one.
- Are you reporting a performance issue or a hang? Please attach a sample. Instructions at https://gitlab.com/gnachman/iterm2/wikis/HowToSample
Performance issue. Videos attached.
Detailed steps to reproduce the problem:
- Latest Shell Integration installed -- if Shell Integration isn't installed it doesn't do this
- Repeatedly use arrow keys on command line to scroll through previous commands or move cursor within currently selected command, especially holding keys down.
- Watch/listen as command line either starts barking at your keystrokes or command history I don't want pops up in relation to a command I did not type
What happened: After a few keypresses working as expected, iTerm2 stops using arrow keys the way I want it to and applies its own agenda. It either starts yelling because it is in a mode where my arrow keys are now unwanted, or it scrolls me through a list of commands matching a command from my buffer that I don't want to match. I have to escape out or click in the window to keep scrolling through my command or command buffer. See attached videos. EditCommandLineFromBuffer What should have happened: It should work like it did before I updated iTerm2 and Shell Integration to the latest. I can't stop it from misbehaving.
Activity
Here's the other video. In this one, I'm just hitting up arrow to scroll through my prior commands buffer. It grabs a command I didn't key in or ask for and makes it a template I didn't want.
This feature has always been a little half-baked. I think it's reasonable to hide the autocomplete window after you press left arrow, but I'm not sure what the best way to handle repeatedly pressing up arrow to go through history would be. Maybe don't open autocomplete if the last keypress was up/down arrow? That's a little hacky. I'm open to better ideas.
changed milestone to %Review for next version
For now, I just disabled the autocompletion. I'm so old-school, anyway, that I am fully accustomed to handling this with bash itself. I realized I was hardly ever using the autocompletion, so now I am just doing what I was always doing, but the issue doesn't arise.
It seems a hairy situation, to be sure. I can't imagine what the solution is for now; I basically agree with everything you've said here.
Quick idea: since the autocompletion pop-up doesn't want arrow keys, perhaps it should deal with them separately; if you're already in autocomplete mode, let an up/down key scroll you up and down in the command buffer, just like it would if you're not in autocomplete mode. Left/right arrows... not so sure.
