Skip to content

Refactor progressbar

username-removed-819582 requested to merge gh-6a115f1b/115/darnir/refactor-progressbar into master

This is a small refactor of the progress bar code based on our discussion on the other pull request.

While this works fine, it will cause new errors on Coverity. This is because I have now marked some functions in src/bar.c as WGET_NONNULL_ALL. However, currently there still exist a few code paths that do not set the filename and hence, we pass a NULL pointer in such cases.

I'd like to fix those cases soon, but this progress bar should work the same as it currently works.

Merge request reports