Skip to content
Snippets Groups Projects

Add comments to Wiki pages

Merged gitlab-qa-bot requested to merge github/fork/seeingidog/add_wiki_comments into master

Created by: seeingidog

Implements comments for wiki pages as mentioned in issue #845 (closed). Two questions:

  1. The comments reference a Wiki object which changes with each edit. Should they point at the project's last Wiki object?
  2. Are the email notifications I added unnecessary?

Let me know if there is anything else. Thanks.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: dzaporozhets

    1. yes, last wiki object
    2. It notifies wiki author?

    By Administrator on 2012-07-20T06:49:03 (imported from GitLab project)

    By Administrator on 2012-07-20T06:49:03 (imported from GitLab)

  • Created by: seeingidog

    1. I've had to use this method to show comments for all revisions of a wiki. Works well.
    2. Are you asking this to be changed to notify the wiki author only? It currently notifies the team.

    By Administrator on 2012-07-20T17:17:59 (imported from GitLab project)

    By Administrator on 2012-07-20T17:17:59 (imported from GitLab)

  • Created by: dzaporozhets

    notify all team is ok. I'll check your PR & merge it right after release 22th :)

    By Administrator on 2012-07-20T17:25:29 (imported from GitLab project)

    By Administrator on 2012-07-20T17:25:29 (imported from GitLab)

Please register or sign in to reply
Loading