Skip to content
Snippets Groups Projects

Fully embrace Ruby 1.9 hash syntax

Merged gitlab-qa-bot requested to merge github/fork/rspeicher/ruby19_hashes into master

Created by: rspeicher

Didn't bother with files in db/, config/, or features/

I realize this is a huge commit. Let me know if breaking it up by directory or something would help.

For reference, accomplished with these commands:

perl -pi -e 's/([^:]):([\w\d_]+)(\s*)=>/\1\2:/g' app/views/**/*.haml
perl -pi -e 's/([^:]):([\w\d_]+)(\s*)=>/\1\2:/g' **/*.rb

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: travisbot

    This pull request fails (merged 77541891 into 1413c23c).

    By Administrator on 2012-08-10T22:33:26 (imported from GitLab project)

    By Administrator on 2012-08-10T22:33:26 (imported from GitLab)

  • Created by: travisbot

    This pull request fails (merged 42d3295d into 1413c23c).

    By Administrator on 2012-08-10T22:46:58 (imported from GitLab project)

    By Administrator on 2012-08-10T22:46:58 (imported from GitLab)

  • Created by: rspeicher

    I'm getting the same feature failure when I run against current master (1413c23c), so I'm not sure what that is. Doesn't seem to be caused by my changes, but I'm not sure.

    By Administrator on 2012-08-10T23:22:50 (imported from GitLab project)

    By Administrator on 2012-08-10T23:22:50 (imported from GitLab)

  • Created by: dzaporozhets

    Yeap. In your case seems like tests passes. Lets merge it:)

    By Administrator on 2012-08-11T08:26:41 (imported from GitLab project)

    By Administrator on 2012-08-11T08:26:41 (imported from GitLab)

Please register or sign in to reply
Loading