Skip to content
Snippets Groups Projects

FactoryGirl and spec cleanup

Merged gitlab-qa-bot requested to merge github/fork/rspeicher/factory_girl into master

Created by: rspeicher

Adds FactoryGirl as we discussed. I didn't go completely crazy with cleaning up specs yet, I wanted to get this merged in first and then I'll start on that.

But this does have one major cleanup: We now only need one seed repository, and it should also eliminate all instances of tests randomly failing because a Project got a duplicate value from Faker. I moved the seed repos from tmp/tests to tmp/repositories, so you'll need to re-run db:seed_fu RAILS_ENV=test.

@randx Please take a look at StubbedRepository -- I wrote this last night before your changes, so there may be some overlap in our methods.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: travisbot

    This pull request passes (merged 39ff033d into b03ee466).

    By Administrator on 2012-08-29T01:40:39 (imported from GitLab project)

    By Administrator on 2012-08-29T01:40:39 (imported from GitLab)

  • Created by: dzaporozhets

    Great! I like it. Only change is about StubbedRepository. Include it to Project only.

    By Administrator on 2012-08-29T05:50:45 (imported from GitLab project)

    By Administrator on 2012-08-29T05:50:45 (imported from GitLab)

  • Created by: rspeicher

    Nice, that simplified things a good deal.

    By Administrator on 2012-08-29T05:56:18 (imported from GitLab project)

    By Administrator on 2012-08-29T05:56:18 (imported from GitLab)

  • Created by: dzaporozhets

    yeap. merging it. Thank you!

    By Administrator on 2012-08-29T05:57:13 (imported from GitLab project)

    By Administrator on 2012-08-29T05:57:13 (imported from GitLab)

  • Created by: dzaporozhets

    Few more steps and project code will be awesome :)

    By Administrator on 2012-08-29T05:58:21 (imported from GitLab project)

    By Administrator on 2012-08-29T05:58:21 (imported from GitLab)

  • Created by: travisbot

    This pull request passes (merged 1dda0848 into b03ee466).

    By Administrator on 2012-08-29T06:03:54 (imported from GitLab project)

    By Administrator on 2012-08-29T06:03:54 (imported from GitLab)

Please register or sign in to reply
Loading