Skip to content
Snippets Groups Projects

use root_url instead of custom web_app_url

Closed gitlab-qa-bot requested to merge github/fork/jouve/use_rails_helper1 into master

Created by: jouve

Hello,

this patch replaces custom web_app_url by standard root_url.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: jouve

    Or should we use Gitlab.config.url ? web_app_url is not good because it does not display the port.

    By Administrator on 2012-09-11T09:02:42 (imported from GitLab project)

    By Administrator on 2012-09-11T09:02:42 (imported from GitLab)

  • Created by: marfillaster

    It should be configuration agnostic and rely on HTTP uri header. I'm not a rails dev but this is possible in php when computed againts script_name and script_filename headers of front web controller.

    Reference: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Request.php#L624-647

    By Administrator on 2012-11-27T01:39:19 (imported from GitLab project)

    By Administrator on 2012-11-27T01:39:19 (imported from GitLab)

  • Created by: riyad

    @jouve @randx Is this outdated since the namespace feature got merged? If so it should be closed.

    By Administrator on 2012-11-28T14:20:34 (imported from GitLab project)

    By Administrator on 2012-11-28T14:20:34 (imported from GitLab)

  • Created by: jouve

    This is still used for admin/groups/:id/edit view. It will become useless if you remove the possibility to edit the URL of group like you did for the URL of projects.

    By Administrator on 2012-11-28T15:03:25 (imported from GitLab project)

    By Administrator on 2012-11-28T15:03:25 (imported from GitLab)

  • Created by: dzaporozhets

    Yeap. We can close this one. Path edit will be removed from admin/groups/:id/edit

    By Administrator on 2012-11-28T15:10:19 (imported from GitLab project)

    By Administrator on 2012-11-28T15:10:19 (imported from GitLab)

Please register or sign in to reply
Loading