Skip to content
Snippets Groups Projects

Change comments order

Merged gitlab-qa-bot requested to merge github/fork/riyad/change-notes-order into master

Created by: riyad

Changes notes order in all circumstances except for the wall.

  • Notes are now oldest to newest, top to bottom (except for the project wall)
  • Refactored notes.js to be able to dynamically load ordinary and reversed notes
  • Properly documented notes.js
  • Fixed bugs regarding the handling (especially deletion) of diff line notes
  • Renamed the notes partials to be more consistently named
  • Extracted notes related stuff (from rendering diffs) into new notes partials

Closes #847 (closed)

Enjoy :)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: dzaporozhets

    wow. Its impressive. I'll definitely take a look tomorrow. I wish it to be part of 2.9

    By Administrator on 2012-09-14T21:21:29 (imported from GitLab project)

    By Administrator on 2012-09-14T21:21:29 (imported from GitLab)

  • Created by: dzaporozhets

    Seems like comments for MR are not working

    By Administrator on 2012-09-14T22:19:57 (imported from GitLab project)

    By Administrator on 2012-09-14T22:19:57 (imported from GitLab)

  • Created by: riyad

    Can you be more specific? It works correctly here.

    By Administrator on 2012-09-14T22:33:50 (imported from GitLab project)

    By Administrator on 2012-09-14T22:33:50 (imported from GitLab)

  • Created by: dzaporozhets

    yeah sure. when i try to comment any diff in MR after form submit comment is not appears

    By Administrator on 2012-09-15T06:41:36 (imported from GitLab project)

    By Administrator on 2012-09-15T06:41:36 (imported from GitLab)

  • Created by: dzaporozhets

    seems lie you forget to call

    for diffs.html.haml

    PerLIneNotes.init();
    

    By Administrator on 2012-09-15T06:46:57 (imported from GitLab project)

    By Administrator on 2012-09-15T06:46:57 (imported from GitLab)

  • Created by: dzaporozhets

    I'll handle it. Thank you for this PR

    By Administrator on 2012-09-15T06:50:05 (imported from GitLab project)

    By Administrator on 2012-09-15T06:50:05 (imported from GitLab)

  • Created by: riyad

    Damn it, I always seem to miss something. Thanks for putting up with me. :)

    By Administrator on 2012-09-15T08:52:02 (imported from GitLab project)

    By Administrator on 2012-09-15T08:52:02 (imported from GitLab)

  • Created by: dzaporozhets

    @Riyad it happens to all of us :) Thank you for PR once more

    By Administrator on 2012-09-15T15:52:55 (imported from GitLab project)

    By Administrator on 2012-09-15T15:52:55 (imported from GitLab)

  • Created by: Mimans

    Could this be applied for changing order in Teambox? If not, do you have any idea how to do that?

    By Administrator on 2013-08-19T14:53:01 (imported from GitLab project)

    By Administrator on 2013-08-19T14:53:01 (imported from GitLab)

Please register or sign in to reply
Loading