Skip to content
Snippets Groups Projects

Update votes when adding notes

Merged gitlab-qa-bot requested to merge github/fork/riyad/update-votes-when-adding-notes into master

Created by: riyad

  • update votes when adding or refreshing comments
  • highlight voting comments in comments list (only for issues and MRs)

Fixes #1466 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: riyad

    Screen shot showing highlighted comments

    screen shot

    By Administrator on 2012-09-15T10:10:21 (imported from GitLab project)

    By Administrator on 2012-09-15T10:10:21 (imported from GitLab)

  • Created by: dzaporozhets

    I dont like left padding you added for comments.
    For me it will be better if we replace left padding + border with light green background like #EFE and red one for downvote #FEE

    By Administrator on 2012-09-17T08:54:32 (imported from GitLab project)

    By Administrator on 2012-09-17T08:54:32 (imported from GitLab)

  • Created by: dzaporozhets

    I can merge this one and change it by myself or you if have some free time

    By Administrator on 2012-09-17T08:57:40 (imported from GitLab project)

    By Administrator on 2012-09-17T08:57:40 (imported from GitLab)

  • Created by: riyad

    I tried different ways of coloring background, like using light colors to fill the background, subtle gadients from corners or vertical ones ... I didn't like it too much ... they all seemed to throw off the look of the whole discussion thread. I got the idea with the border from the diff inline notes ... I experimented with the positioning and came to the conclusion that the left border was the place where it would look like it belonged to the note, but it was not "disrupting the flow". Another idea I have not yet explored is a background image (maybe for the top right corner) where you have a gradient (color from top right -> white towards the center) with a white "+1" or "-1" stencil in it.

    I won't be able to work on it for at least a few days so you go ahead (your CSS skills seem to be better anyway ;) ).

    By Administrator on 2012-09-17T12:57:48 (imported from GitLab project)

    By Administrator on 2012-09-17T12:57:48 (imported from GitLab)

  • Created by: dzaporozhets

    @Riyad ok. I'll handle it. Thank you for explanation :)

    By Administrator on 2012-09-17T12:31:01 (imported from GitLab project)

    By Administrator on 2012-09-17T12:31:01 (imported from GitLab)

  • Created by: riyad

    @randx I'm curious what you'll come up with. :)

    By Administrator on 2012-09-17T12:56:47 (imported from GitLab project)

    By Administrator on 2012-09-17T12:56:47 (imported from GitLab)

  • Created by: dzaporozhets

    I dont know. Maybe even this one :) sample

    By Administrator on 2012-09-17T14:30:30 (imported from GitLab project)

    By Administrator on 2012-09-17T14:30:30 (imported from GitLab)

  • Created by: riyad

    Hmm ... looks good, actually :) ... but to avoid confusion, make sure it doesn't look too much like a button, but more like a badge/label.

    By Administrator on 2012-09-17T14:34:38 (imported from GitLab project)

    By Administrator on 2012-09-17T14:34:38 (imported from GitLab)

  • Created by: SaitoWu

    I like @randx 's version. :thumbsup:

    By Administrator on 2012-09-18T02:04:11 (imported from GitLab project)

    By Administrator on 2012-09-18T02:04:11 (imported from GitLab)

Please register or sign in to reply
Loading