Skip to content
Snippets Groups Projects

Routing specs and cleanup

Merged gitlab-qa-bot requested to merge github/fork/rspeicher/route_specs into master

Created by: rspeicher

First, this adds routing specs. Why? Because I was going to modify the routes and wanted to make sure the current ones still worked after my changes.

Then I made a few changes:

  • Adds an AdminController base controller for the other Admin controllers to subclass. It currently handles setting the layout and authorizing an admin and just removes some duplication from those controllers.
  • Style changes in routes.rb, mostly 1.9 Hash syntax and alignment and spacing.
  • Removes a few actions that are no longer used from various controllers.
  • Removes unused actions from various routes ("logs" had all the default actions but only used "show", for instance.)
  • Removes the 'team' action from the Projects controller and instead uses the 'index' action in TeamMembers.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: riyad

    Wouldn't it be better to split the routing specs into one file per controller?

    By Administrator on 2012-09-16T14:34:10 (imported from GitLab project)

    By Administrator on 2012-09-16T14:34:10 (imported from GitLab)

  • Created by: rspeicher

    Yeah, probably. I can do that if we want.

    By Administrator on 2012-09-16T14:35:53 (imported from GitLab project)

    By Administrator on 2012-09-16T14:35:53 (imported from GitLab)

  • Created by: rspeicher

    I dunno, while there's definitely a downside to a file that big, I think there's definitely a positive side to seeing them all in one file; so many of them are related since they belong to Projects.

    There's probably a better way to split it up than just one file per controller. I'll think on it some more.

    By Administrator on 2012-09-16T15:43:42 (imported from GitLab project)

    By Administrator on 2012-09-16T15:43:42 (imported from GitLab)

  • Created by: riyad

    I'll trust your jundgement. ;)

    By Administrator on 2012-09-16T16:26:11 (imported from GitLab project)

    By Administrator on 2012-09-16T16:26:11 (imported from GitLab)

  • Created by: rspeicher

    That split them up a bit.

    By Administrator on 2012-09-16T16:43:24 (imported from GitLab project)

    By Administrator on 2012-09-16T16:43:24 (imported from GitLab)

  • Created by: dzaporozhets

    @tsigo great cleanup. You make my dreams :)

    By Administrator on 2012-09-16T18:19:49 (imported from GitLab project)

    By Administrator on 2012-09-16T18:19:49 (imported from GitLab)

Please register or sign in to reply
Loading