Skip to content
Snippets Groups Projects

API attributes refactoring

Merged API attributes refactoring
github/fork/AlexDenisov/api_attrs_refactoring into master
Merged gitlab-qa-bot requested to merge github/fork/AlexDenisov/api_attrs_refactoring into master

Created by: AlexDenisov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: rspeicher

    existed_attributes doesn't really make sense in English. Maybe existing_attributes, but to me that doesn't describe what it does well enough. Maybe attributes_for_keys(...) or attributes_from_param_keys?

    By Administrator on 2012-09-16T17:02:29 (imported from GitLab project)

    By Administrator on 2012-09-16T17:02:29 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: AlexDenisov

    Sorry for my English and thank you :) I like attributes_for_keys.

    By Administrator on 2012-09-16T17:06:21 (imported from GitLab project)

    By Administrator on 2012-09-16T17:06:21 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: rspeicher

    No need to apologize at all, I know it's not everyone's primary language.

    By Administrator on 2012-09-16T17:07:24 (imported from GitLab project)

    By Administrator on 2012-09-16T17:07:24 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @AlexDenisov thank you. I merge this one

    By Administrator on 2012-09-16T19:27:45 (imported from GitLab project)

    By Administrator on 2012-09-16T19:27:45 (imported from GitLab)

Please register or sign in to reply