Omniauth adjustments for Shibboleth integration.
Created by: TiagoTT
Following this discussion: https://groups.google.com/forum/#!topic/gitlabhq/t860p0HWXFU
These are the changes I present to unify Omniauth provider handling and to add support to Shibboleth authentication. The omniauth-shibboleth module has been changed to improve configuration and is pending upstream approval, so I have included my own version from the Gemfile.
Merge request reports
Activity
Created by: TiagoTT
I noticed that there are two image files missing now:
vendor/assets/images/authbuttons/shibboleth_32.png vendor/assets/images/authbuttons/shibboleth_64.pngI will resize the Shibboleth logo and add these as soon as possible.
By Administrator on 2012-09-19T11:48:30 (imported from GitLab project)
By Administrator on 2012-09-19T11:48:30 (imported from GitLab)
Created by: TiagoTT
The logo files should not be the Shibboleth logo, but the authentication provider logo instead. Each deployment should place their own logo files in:
vendor/assets/images/authbuttons/shibboleth_32.png vendor/assets/images/authbuttons/shibboleth_64.pngI am using my company's logo there.
By Administrator on 2012-09-19T17:54:35 (imported from GitLab project)
By Administrator on 2012-09-19T17:54:35 (imported from GitLab)
Created by: TiagoTT
I removed the tests which covered the code I removed. I aimed to unify the code for omniauth user creation, thus I removed some code I found redundant.
As I wasn't completely sure about the way I did this, I asked for a careful review on the commit message: https://github.com/TiagoTT/gitlabhq/commit/f659ec0f26f4d569f68dd1ad3196bf01a54d4cd8
What do you think about it?
By Administrator on 2012-10-12T15:03:41 (imported from GitLab project)
By Administrator on 2012-10-12T15:03:41 (imported from GitLab)
Created by: frohoff
I'd love to see this get merged as it would make it much easier to integrate non-OAuth omniauth modules in a clean way without having to modify the gitlab source code.
By Administrator on 2012-12-05T16:29:56 (imported from GitLab project)
By Administrator on 2012-12-05T16:29:56 (imported from GitLab)
Created by: TiagoTT
I am dropping this pull request, and will submit a new one with cleaner changesets. Which branch should I take as starting point? master or latest stable 4.1? To which branch should I make the pull request?
By Administrator on 2013-01-29T18:59:44 (imported from GitLab project)
By Administrator on 2013-01-29T18:59:44 (imported from GitLab)
Created by: coveralls
Changes Unknown when pulling 4d15e5cc on TiagoTT:master into * on gitlabhq:master*.
By Administrator on 2013-12-04T14:49:11 (imported from GitLab project)
By Administrator on 2013-12-04T14:49:11 (imported from GitLab)
