Skip to content
Snippets Groups Projects

Code cleanup on NoteObserver and Notify

Merged Code cleanup on NoteObserver and Notify
github/fork/riyad/cleanup-note-observer-and-notifications into master
Merged gitlab-qa-bot requested to merge github/fork/riyad/cleanup-note-observer-and-notifications into master

Created by: riyad

  • reorders and groups methods in Notify
  • rename methods on NoteObserver
  • add explanations to fixes in #1694 to make that case more obvious
  • update NoteObserver specs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
spec/observers/note_observer_spec.rb
3 3 describe NoteObserver do
4 4 subject { NoteObserver.instance }
5 5
6 let(:team_without_author) { (1..2).map { |n| double :user, id: n } }
7 let(:delivery_success) { double deliver: true }
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: robbkidd

    :thumbsup: I like that you gave this a name.

    By Administrator on 2012-10-17T23:25:00 (imported from GitLab project)

    By Administrator on 2012-10-17T23:25:00 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: robbkidd

    :thumbsup: Good cleanup.

    By Administrator on 2012-10-15T17:37:44 (imported from GitLab project)

    By Administrator on 2012-10-15T17:37:44 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Rebased.

    By Administrator on 2012-10-17T23:28:25 (imported from GitLab project)

    By Administrator on 2012-10-17T23:28:25 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Thanks

    By Administrator on 2012-10-18T07:26:41 (imported from GitLab project)

    By Administrator on 2012-10-18T07:26:41 (imported from GitLab)

    • Please register or sign in to reply