Update author info in tree listing
Created by: riyad
Makes the commit information in the tree view more polished.
- adds the author's avatar
- shows more of the commit message
- fixes wrong argument order in
Team#team_member_by_name_or_email - adds
CommitDecorator#author_linkand pulls some code out of the views - fixes a bug where the link was missing, when the author wasn't a project member (it will now fall back linking to the author's email)
new look:
Merge request reports
Activity
Created by: sroth80021
FWIW, I like parts of both the old and new. I prefer having the Username at the beginning of the string. However, I do like having the commiter icon and longer commit message.
By Administrator on 2012-10-17T13:14:25 (imported from GitLab project)
By Administrator on 2012-10-17T13:14:25 (imported from GitLab)
Created by: riyad
I'm really unhappy the way it looks at the moment so I had one more go. The styles are lighter now, more similar to the current look. I've come up with 4 variants in total.
variant 1: "packed" all in one line, author in front
variant 2: "packed" all in one line, author in the back
variant 3: separate author column in front of the message
variant 4: separate author column behind the message
By Administrator on 2012-10-17T15:45:25 (imported from GitLab project)
By Administrator on 2012-10-17T15:45:25 (imported from GitLab)
Created by: riyad
lol, I just realized what's wrong with the initial PR and variant 2 above: having randomly placed images and color changes really mess up the "visual columns" in the table. No wonder it was rejected. ;) It seems so obvious now. :)
By Administrator on 2012-10-17T16:02:00 (imported from GitLab project)
By Administrator on 2012-10-17T16:02:00 (imported from GitLab)
Created by: putneyj
+1 for @sroth80021's order
By Administrator on 2012-10-17T16:00:03 (imported from GitLab project)
By Administrator on 2012-10-17T16:00:03 (imported from GitLab)
Created by: dzaporozhets
only first one. I think its strange to separate author & commit message. The problem with avatars that they takes your attention instead of files names(which are more prioritized) I can accept first one. 2,3,4 is not ok for me.
By Administrator on 2012-10-17T17:18:19 (imported from GitLab project)
By Administrator on 2012-10-17T17:18:19 (imported from GitLab)
Created by: riyad
@randx I think thats where we differ. In my opinion it is more important what changed (i.e. the commit message) not who did it. Thats why I think the column should start with the message, not with the author. But it really looks bad, when it is packed all in one line (as in variant 2). So I tried separating the columns and it didn't look bad. :) I think with time you could come to like something like variant 3. ;)
By Administrator on 2012-10-17T19:24:44 (imported from GitLab project)
By Administrator on 2012-10-17T19:24:44 (imported from GitLab)
Created by: riyad
@randx I really have a hard time understanding your reason. :( What do you like so much about the way it is now, that it can/should not be changed and that can't be found/incorporated into the update?
By Administrator on 2012-10-17T20:44:09 (imported from GitLab project)
By Administrator on 2012-10-17T20:44:09 (imported from GitLab)
Created by: dzaporozhets
Current solution is clean and simple. No sense to change it just for change. Adding separate column for author doesnt make sense for me. Primary object of tree view is file names.
By Administrator on 2012-10-18T07:36:45 (imported from GitLab project)
By Administrator on 2012-10-18T07:36:45 (imported from GitLab)
Created by: sroth80021
Reading over the recent comments, I agree with @randx -- changing my vote to #1 (closed). I still consider the avatar and extra commit text an improvement over today.
By Administrator on 2012-10-18T14:26:02 (imported from GitLab project)
By Administrator on 2012-10-18T14:26:02 (imported from GitLab)
