Refactor Satellite Code

Created by: riyad

Refactors and documents the satellite code

• Move anything satellite related into the Gitlab::Satellite module
• Extract common code from actions (i.e. edit file, automerge) into the new Gitlab::Satellite::Action class
• Rename all actions *Action and make them inherit Action
• Move satellite cleaning code from actions into Satellite
• Move locking into Satellite
• Log all failed Git commands in actions
• Fix Git timeout being ignored
• Update method docs and clarify code

Created by: vsizov

looks good. I'll test it tomorrow. I want to say something. Guys, why most of all you are doing only refactoring? This is infinite process: refactoring - bug - fix - refactoring - bug - fix. We have some functionality that works fine and looks not bad (sometimes even cool). I am a little bit tired due to this process. If you want to help, please let's do new features, fix bug and refactoring (when needed).

By Administrator on 2012-10-26T11:19:18 (imported from GitLab project)

By Administrator on 2012-10-26T11:19:18 (imported from GitLab)

Created by: vsizov

Roadmap will be public soon.

By Administrator on 2012-10-26T09:40:13 (imported from GitLab project)

By Administrator on 2012-10-26T09:40:13 (imported from GitLab)

Created by: riyad

I can understand that it's tiring, when you are familiar with most of the code, but believe me it has several benefits. :) Some times it is necessary to take a step back and look at what you have achieved and do a little house keeping. For example, some code only makes sense if you know its history. But this knowledge is especially not available to new community members. So refactorings are a tool to familiarize yourself with the code, improve on the architecture and testability and optimize it not (always) for execution speed, but (more) for ease of understanding. Easy to understand and clean code, helps to speed up bug-fixing, reviews, feature development and getting new contributors on board. So, there is a benefit for your patience. ;)

By Administrator on 2012-10-26T10:48:39 (imported from GitLab project)

By Administrator on 2012-10-26T10:48:39 (imported from GitLab)

Created by: vsizov

:) sure

By Administrator on 2012-10-26T11:18:36 (imported from GitLab project)

By Administrator on 2012-10-26T11:18:36 (imported from GitLab)

Created by: dzaporozhets

looks cool. It should be properly tested before merge :)

By Administrator on 2012-10-26T11:23:24 (imported from GitLab project)

By Administrator on 2012-10-26T11:23:24 (imported from GitLab)

Created by: dzaporozhets

@Riyad I'll merge it. If we find any missed bugs - we have enough time till next release :) Thank you for awesome refactoring

By Administrator on 2012-10-29T11:12:18 (imported from GitLab project)

By Administrator on 2012-10-29T11:12:18 (imported from GitLab)

Created by: riyad

I updated https://github.com/gitlabhq/gitlabhq/wiki/GitLab-Under-the-Hood---Merging-and-Editing-Through-the-Web-Interface accordingly. :)

By Administrator on 2012-10-29T13:15:05 (imported from GitLab project)

By Administrator on 2012-10-29T13:15:05 (imported from GitLab)

Created by: vsizov

@Riyad Thanks

By Administrator on 2012-10-29T22:52:59 (imported from GitLab project)

By Administrator on 2012-10-29T22:52:59 (imported from GitLab)