Skip to content

Add Milestone details for Merge Requests

gitlab-qa-bot requested to merge github/fork/piffio/public_submission_milestones_for_mr into master

Created by: piffio

Hi,

In our organisation we follow a workflow for which it makes sense to assign Merge Requests to a Milestone, since we actually accept submissions over a certain time span, and than we have a merge window during which a person will merge in the next stable release all the MR marked as OK.

The idea is that:

  • Someone will do the code review on the MR, and Set the Milestone field if the MR is accepted
  • The person in charge for packing the next release will have to browse through all the MR marked for that Milestone and merge them all

Additionally, we plan on adding an automated tool (Jenkins? Travis? A custom script?) that does the same, checking that all the MR marked as OK for the next milestone apply and build correctly on the stable branch.

In this MR I've added

  • Milestone detail when creating / editing a MR
  • Ability to filter for Assignee / Milestone in the MR list view
  • Show the amount of MR associated with a Milestone in the Milestone list view
  • Show the amount of open MR in the Milestone details view

Let me know if you have any comments, additional requests, strong objections. Please keep in mind that I'm not a Ruby developer and I really welcome suggestions on how to do it "better".

Here are a few screenshots

MR Listing MR Listing

MR Detail MR Detail

MR New / Edit MR New / Edit

Milestones Listing Milestones Listing

Milestones Detail Milestones Detail

Merge request reports