Skip to content
Snippets Groups Projects

allow customize gravatar url

Merged gitlab-qa-bot requested to merge github/fork/linniksa/patch-custom-gravatar into master

Created by: linniksa

it will be very useful for people who have their own implementation of gravatar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: linniksa

    @randx How about merge this?

    By Administrator on 2012-12-01T08:52:25 (imported from GitLab project)

    By Administrator on 2012-12-01T08:52:25 (imported from GitLab)

  • Created by: ariejan

    How does having your own gravatar server make sense for Gitlab? I fail to see the use case for 99% of the users here.

    By Administrator on 2012-12-06T11:48:04 (imported from GitLab project)

    By Administrator on 2012-12-06T11:48:04 (imported from GitLab)

  • Created by: linniksa

    in our company we have local address book with user photos and gravatar like interface to retrieve avatar by email, and use it with many services (own and 3rd party) and we want see users avatars in gitlab too.

    By Administrator on 2012-12-06T13:37:57 (imported from GitLab project)

    By Administrator on 2012-12-06T13:37:57 (imported from GitLab)

  • Created by: linniksa

    and btw it better that disable avatar completely (see #1237 (closed))

    By Administrator on 2012-12-06T13:40:42 (imported from GitLab project)

    By Administrator on 2012-12-06T13:40:42 (imported from GitLab)

  • Created by: ariejan

    Meh. I don't think this actually serves a broad public, but fine.

    Can you make sure:

    • There are specs for this.
    • The specs are green in your feature branch

    By Administrator on 2012-12-06T13:46:08 (imported from GitLab project)

    By Administrator on 2012-12-06T13:46:08 (imported from GitLab)

  • Created by: linniksa

    @ariejan write cucumber "tests" for that feature?

    By Administrator on 2012-12-06T13:49:44 (imported from GitLab project)

    By Administrator on 2012-12-06T13:49:44 (imported from GitLab)

  • Created by: ariejan

    Yes? For all I know it breaks current gravatar support or is completely breaks gitlab. The spec suite is not failing, so there's no way of telling.

    By Administrator on 2012-12-06T13:51:10 (imported from GitLab project)

    By Administrator on 2012-12-06T13:51:10 (imported from GitLab)

  • Created by: linniksa

    @ariejan i rebase this PR and add some tests

    By Administrator on 2012-12-06T21:01:50 (imported from GitLab project)

    By Administrator on 2012-12-06T21:01:50 (imported from GitLab)

Please register or sign in to reply
Loading