Skip to content
Snippets Groups Projects

Add optional signup

Merged Add optional signup
github/fork/dosire/allow_self_signup into master
Merged gitlab-qa-bot requested to merge github/fork/dosire/allow_self_signup into master

Created by: maxlazio

Adds an option to gitlab config that will enable user signup. By default, signup is disabled. When signup is enabled, email that user receives on signup doesn't contain the password for security reasons.

This option is useful for companies and universities where administrator cannot add all users manually. https://groups.google.com/d/msg/gitlabhq/ANAmyqP4m5U/ZqBGEWWVbhsJ

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
app/controllers/registrations_controller.rb 0 → 100644
1 class RegistrationsController < Devise::RegistrationsController
2 before_filter :signup_enabled?
3
4 private
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: ariejan

    Please make any method in a controller that is not an action private.

    By Administrator on 2013-01-18T10:58:44 (imported from GitLab project)

    By Administrator on 2013-01-18T10:58:44 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 296cdd59
    • app/models/user.rb
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: ariejan

      Would it make sense to also include :confirmable here?

      By Administrator on 2013-01-18T10:58:44 (imported from GitLab project)

      By Administrator on 2013-01-18T10:58:44 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 296cdd59
    • app/views/devise/registrations/new.html.erb deleted 100644 → 0
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: ariejan

      This could use a little formatting love :love_hotel:

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab project)

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: ariejan

    I'm missing feature specs for the entire process (except the sending of the email).

    Also, test suite seems broken, you mee need to update your branch.

    By Administrator on 2012-12-07T09:25:05 (imported from GitLab project)

    By Administrator on 2012-12-07T09:25:05 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 296cdd59
    • app/views/devise/registrations/new.html.erb deleted 100644 → 0
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: riyad

      Also please convert this to Haml.

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab project)

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: maxlazio

    @ariejan Thank you very much for your suggestions. I've also added more tests and after updating the branch I have all tests pass: https://gist.github.com/5e8f0d6b764fe0198915 https://gist.github.com/735c6dccb1131e572476

    By Administrator on 2012-12-11T10:56:40 (imported from GitLab project)

    By Administrator on 2012-12-11T10:56:40 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 296cdd59
    • app/models/user.rb
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: maxlazio

      That is a great idea. However, I would like to keep that separate from this MR and make it a separate feature. Would that be an option?

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab project)

      By Administrator on 2013-01-18T10:58:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: kirantpatil

    what default role is assigned to signed user ? IMHO assigning guest role by default is better.

    By Administrator on 2012-12-17T05:25:56 (imported from GitLab project)

    By Administrator on 2012-12-17T05:25:56 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Thank you. Can you please make it mergeable? I'd like to accept it

    By Administrator on 2013-01-02T10:27:29 (imported from GitLab project)

    By Administrator on 2013-01-02T10:27:29 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    :thumbsup:

    By Administrator on 2013-01-02T16:13:04 (imported from GitLab project)

    By Administrator on 2013-01-02T16:13:04 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: maxlazio

    @randx Done. Please let me know if there is anything else.

    By Administrator on 2013-01-18T11:22:38 (imported from GitLab project)

    By Administrator on 2013-01-18T11:22:38 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @maxlazio seems ok for me

    By Administrator on 2013-01-18T13:17:27 (imported from GitLab project)

    By Administrator on 2013-01-18T13:17:27 (imported from GitLab)

    • Please register or sign in to reply