SCSS/CSS refactor
Created by: koenpunt
I could sum up al my commit messages here, but basically it comes down to a more uniform SCSS and some more declarative naming of mixins and variables.
And my main reason to do this; the clutter of different definitions of classnames on elements. Before half of all were separated with underscores _
and the other half with dashes -
. Now its all dashes.
Ultimately there should be some kind of code quality control in GitLab for SASS like https://github.com/twitter/recess for LESS
Merge request reports
Activity
Created by: koenpunt
In the scenario:
I change my application theme
there is an failure which statesexpected css "body.ui-color" to return something
, but redoing the steps described in the feature in the browser myself works well, so i'm not sure where the problem lies.By Administrator on 2012-11-28T23:21:28 (imported from GitLab project)
By Administrator on 2012-11-28T23:21:28 (imported from GitLab)
Created by: dzaporozhets
First of all thank you! Its great PR but its a huge one. It requires from me to check every page for ui. I dont have so much time. I can take few first commits now and look at rest of it after 3.2 only.
By Administrator on 2012-11-29T06:49:17 (imported from GitLab project)
By Administrator on 2012-11-29T06:49:17 (imported from GitLab)