Skip to content
Snippets Groups Projects

SCSS/CSS refactor

Closed gitlab-qa-bot requested to merge github/fork/koenpunt/scss-css-refactor into master

Created by: koenpunt

I could sum up al my commit messages here, but basically it comes down to a more uniform SCSS and some more declarative naming of mixins and variables. And my main reason to do this; the clutter of different definitions of classnames on elements. Before half of all were separated with underscores _ and the other half with dashes -. Now its all dashes.

Ultimately there should be some kind of code quality control in GitLab for SASS like https://github.com/twitter/recess for LESS

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: koenpunt

    In the scenario: I change my application theme there is an failure which states expected css "body.ui-color" to return something, but redoing the steps described in the feature in the browser myself works well, so i'm not sure where the problem lies.

    By Administrator on 2012-11-28T23:21:28 (imported from GitLab project)

    By Administrator on 2012-11-28T23:21:28 (imported from GitLab)

  • Created by: dzaporozhets

    First of all thank you! Its great PR but its a huge one. It requires from me to check every page for ui. I dont have so much time. I can take few first commits now and look at rest of it after 3.2 only.

    By Administrator on 2012-11-29T06:49:17 (imported from GitLab project)

    By Administrator on 2012-11-29T06:49:17 (imported from GitLab)

  • Created by: koenpunt

    Ok, I can understand that. Should I split it in separate PR's?

    By Administrator on 2012-11-29T09:40:40 (imported from GitLab project)

    By Administrator on 2012-11-29T09:40:40 (imported from GitLab)

  • Created by: dzaporozhets

    @koenpunt yes it will be great

    By Administrator on 2012-11-29T11:11:39 (imported from GitLab project)

    By Administrator on 2012-11-29T11:11:39 (imported from GitLab)

  • Created by: koenpunt

    Closing this in favor of #2117

    By Administrator on 2012-12-01T13:48:52 (imported from GitLab project)

    By Administrator on 2012-12-01T13:48:52 (imported from GitLab)

Please register or sign in to reply
Loading