Fixed #1509 by converting the entities in js
Created by: koenpunt
Converted BranchGraph to a class and now loads the JSON data asynchronously
Merge request reports
Activity
1 var commits = {}, 2 comms = {}, 3 pixelsX = [], 4 pixelsY = [], 5 mmax = Math.max, 6 mtime = 0, 7 mspace = 0, 8 parents = {}, 9 ii = 0, 10 colors = ["#000"]; 1 !function(){ 1 var commits = {}, 2 comms = {}, 3 pixelsX = [], 4 pixelsY = [], 5 mmax = Math.max, 6 mtime = 0, 7 mspace = 0, 8 parents = {}, 9 ii = 0, 10 colors = ["#000"]; 1 !function(){ Created by: koenpunt
It makes the function an expression, so it is callable. For more info on this see: http://stackoverflow.com/a/5654929/189431
By Administrator on 2012-12-07T21:09:47 (imported from GitLab project)
By Administrator on 2012-12-07T21:09:47 (imported from GitLab)
1 var commits = {}, 2 comms = {}, 3 pixelsX = [], 4 pixelsY = [], 5 mmax = Math.max, 6 mtime = 0, 7 mspace = 0, 8 parents = {}, 9 ii = 0, 10 colors = ["#000"]; 1 !function(){ Created by: riyad
I see ... nice trick ;) ... but I'd rather see the
(function() {})()style ...- it makes it "clearer" (through the extra
)) for the reader that the character in front (i.e.!or() is related to the invocation - it avoids "overloading"
!with another "meaning"
just my thoughts ;)
By Administrator on 2012-12-07T21:09:47 (imported from GitLab project)
By Administrator on 2012-12-07T21:09:47 (imported from GitLab)
- it makes it "clearer" (through the extra
1 var commits = {}, 2 comms = {}, 3 pixelsX = [], 4 pixelsY = [], 5 mmax = Math.max, 6 mtime = 0, 7 mspace = 0, 8 parents = {}, 9 ii = 0, 10 colors = ["#000"]; 1 !function(){ Created by: koenpunt
Oh well, the thing is that this script needs a major overhaul anyway, for now it is just issue solving, and keeping the variables out of global scope :)
By Administrator on 2012-12-07T21:09:48 (imported from GitLab project)
By Administrator on 2012-12-07T21:09:48 (imported from GitLab)
