Skip to content
Snippets Groups Projects

added about page

Closed gitlab-qa-bot requested to merge github/fork/jojosch/feature-about-page into master

Created by: jojosch

see #1993 (closed) and #2158 (closed)

Questions:

  • is there a function/variable to get the admin email?
  • should the /help index action redirect to the about index action?
  • any more output on about page?

New Features:

  • Add about to dashboard navigation
  • Add about to sidebar on bottom
  • Add about to main navigation
  • Moved help-OL to partial.
  • Included help-OL-partial in about page

About & Help icon in top navigation: Bildschirmfoto vom 2012-12-08 11:15:45.png

About & Help in sidebar navigation on dashboard Bildschirmfoto vom 2012-12-08 11:15:51.png

About page with help-ol partial Bildschirmfoto vom 2012-12-08 11:16:20.png

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: ariejan

    Some points:

    By Administrator on 2012-12-09T10:23:46 (imported from GitLab project)

    By Administrator on 2012-12-09T10:23:46 (imported from GitLab)

  • Created by: jojosch

    renamed link text to "Info". added Ruby version to about page.

    By Administrator on 2012-12-09T10:52:08 (imported from GitLab project)

    By Administrator on 2012-12-09T10:52:08 (imported from GitLab)

  • Created by: riyad

    Some suggestions from me :)

    • Add an help icon to the top bar
    • Call the about link what it is: "About GitLab" try not mixing it with "Help" at first
    • On the about page itself create a better visual structure:
      1. Introduction "You are using GitLab. GitLab is an open source code hosting solution built around Git."
      2. Getting news: Website, twitter, etc.
      3. Issues: Self help (e.g. using the help pages, searching) -> Ask local support (add an support_email option to gitlab.yml) -> Ask Support Forum -> Follow contribution guide to submit an issue on GitHub
      4. Improving/Extending GitLab: follow contribution guide, find us on GitHub, ...
    • in appropriate places "embed" the CONTRIBUTING.md (hidden at first but expandable, e.g.below the "Help us make GitLab more awsome ..." line)
    • Group the help links (like on the bottom of GitHub) (use columns like "Administration", "Hooks/APIs", "Usage")

    By Administrator on 2012-12-10T14:37:59 (imported from GitLab project)

    By Administrator on 2012-12-10T14:37:59 (imported from GitLab)

  • Created by: jojosch

    updated the about page

    By Administrator on 2013-01-01T15:38:33 (imported from GitLab project)

    By Administrator on 2013-01-01T15:38:33 (imported from GitLab)

  • Created by: jojosch

    updated the about page with the new help-pages layout.

    Overview: Dashboard GitLab

    Contributing: Dashboard GitLab_contrib_open

    By Administrator on 2013-01-16T16:47:17 (imported from GitLab project)

    By Administrator on 2013-01-16T16:47:17 (imported from GitLab)

  • Created by: tvb

    While I like the setup, I think 'About Gitlab' and 'Getting help' blocks could reside next to each other for better page filling. Also 'About this installation' should be put on top.

    By Administrator on 2013-01-16T16:53:53 (imported from GitLab project)

    By Administrator on 2013-01-16T16:53:53 (imported from GitLab)

  • Created by: jojosch

    about_gitlab_redesign

    (fixed the typo "awsome" > "awesome")

    By Administrator on 2013-01-16T17:03:45 (imported from GitLab project)

    By Administrator on 2013-01-16T17:03:45 (imported from GitLab)

  • Created by: tvb

    Better. Why is there an 'Getting Help' text block and a 'Help' block? Should be merged. 'About Gitlab' should imo be placed as last together with 'Help us make...'.

    By Administrator on 2013-01-16T17:08:59 (imported from GitLab project)

    By Administrator on 2013-01-16T17:08:59 (imported from GitLab)

  • gitlab-qa-bot
1 class AboutController < ApplicationController
2 def index
3
4 # check Gitolite version
5 gitolite_home = File.expand_path("~#{Gitlab.config.gitolite.ssh_user}")
  • Created by: riyad

    This is not right ... it should be removed (see below).

    By Administrator on 2013-01-19T14:47:44 (imported from GitLab project)

    By Administrator on 2013-01-19T14:47:44 (imported from GitLab)

  • gitlab-qa-bot
  • 1 class AboutController < ApplicationController
    2 def index
    3
    4 # check Gitolite version
    5 gitolite_home = File.expand_path("~#{Gitlab.config.gitolite.ssh_user}")
    6 gitolite_version_file = "#{gitolite_home}/gitolite/src/VERSION"
    7 @gitolite_version = if File.exists?(gitolite_version_file) && File.readable?(gitolite_version_file)
    8 File.read(gitolite_version_file)
    9 end
    10 @gitolite_version ||= "unknown"
    • Created by: riyad

      Move this below the if block and use the ||= operator. This is Ruby and not C. ;)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab project)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %p.lead You are using GitLab. GitLab is an open source code hosting solution built around Git.
    2
    • Created by: riyad

      You don't need this here. The tab already says it.

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab project)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %p.lead You are using GitLab. GitLab is an open source code hosting solution built around Git.
    2
    3
    4
    5 %h2 About this Installation
    6
    7 %div.row
    8 - unless Gitlab.config.gitlab.admin_email.empty?
    9 %div.span3
    10 %p Admin E-Mail:
    11 %pre.dark #{mail_to(Gitlab.config.gitlab.admin_email)}
    12 %div.span3
    13 %p GitLab Version:
    • Created by: riyad

      Make the spans use space evenly.

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab project)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab)

  • gitlab-qa-bot
  • 24 %h2 Getting Help
    25
    26 =render 'help/help_pages'
    27
    28
    29
    30 %h2 Help us make GitLab more awesome
    31
    32 #contribute.accordion
    33 .accordion-group
    34 .accordion-heading
    35 %a.accordion-toggle{"data-parent" => "#contribute", "data-toggle" => "collapse", :href => "#contribute_content"}
    36 Contribution Guide
    37 #contribute_content.accordion-body.collapse
    38 .accordion-inner
    39 .file_content.wiki
    • Created by: riyad

      the text doesn't need to be %strong if it can be distinguished from the following text (i.e. the links) by color ;)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab project)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab)

  • Created by: riyad

    It looks better and better ... it still needs some refinement though. :) @tristanvanbokkem good remarks. :) There is also no obligation to keep the blocks as is. ;) The middle section needs some love ... it's not yet well laid out.

    By Administrator on 2013-01-17T00:37:25 (imported from GitLab project)

    By Administrator on 2013-01-17T00:37:25 (imported from GitLab)

  • Created by: riyad

    Maybe the "About GitLab" section could move to the bottom of the page. And leave the middle section to be only two columns.

    By Administrator on 2013-01-17T00:38:46 (imported from GitLab project)

    By Administrator on 2013-01-17T00:38:46 (imported from GitLab)

  • gitlab-qa-bot
  • 1 %p.lead You are using GitLab. GitLab is an open source code hosting solution built around Git.
    2
    3
    4
    • Created by: riyad

      Don't use them if you don't need them ... IMHO they are not needed here. You can still easily make out the different sections of the page.

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab project)

      By Administrator on 2013-01-19T14:47:45 (imported from GitLab)

  • Created by: jojosch

    gitlab_about_layout_new

    By Administrator on 2013-01-17T08:28:58 (imported from GitLab project)

    By Administrator on 2013-01-17T08:28:58 (imported from GitLab)

  • Created by: riyad

    Can you squash the commits?

    By Administrator on 2013-01-17T21:11:36 (imported from GitLab project)

    By Administrator on 2013-01-17T21:11:36 (imported from GitLab)

  • Created by: jojosch

    rebased and squashed.

    By Administrator on 2013-01-17T21:29:02 (imported from GitLab project)

    By Administrator on 2013-01-17T21:29:02 (imported from GitLab)

  • Created by: jojosch

    rebased on latest help-pages changes.

    Dashboard GitLab

    By Administrator on 2013-01-19T14:49:34 (imported from GitLab project)

    By Administrator on 2013-01-19T14:49:34 (imported from GitLab)

  • Created by: riyad

    see #2666 for a discussion on the topic

    By Administrator on 2013-01-26T18:49:37 (imported from GitLab project)

    By Administrator on 2013-01-26T18:49:37 (imported from GitLab)

  • Please register or sign in to reply
    Loading