Skip to content
Snippets Groups Projects

Fixed Postgresql Notes search issue (integer vs string) v2.

Closed Fixed Postgresql Notes search issue (integer vs string) v2.
github/fork/jozefvaclavik/master into master
Closed gitlab-qa-bot requested to merge github/fork/jozefvaclavik/master into master

Created by: jozefvaclavik

I created app/roles/noteable.rb where I implemented necessary changes. This file is included in app/model/issue.rb, app/model/snippet.rb, app/model/wiki.rb, and in app/model/merge_request.rb where I also changed mr_and_commit_notes. I hope everything is Ok now.

Improved #2234 Fixes #1957 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Do the tests work for you?

    By Administrator on 2012-12-10T12:34:50 (imported from GitLab project)

    By Administrator on 2012-12-10T12:34:50 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    I have played around and this is not going to work. It breaks all the other association methods provided by Rails. So back to square one (aka #2185 (closed)). :(

    By Administrator on 2012-12-10T13:07:41 (imported from GitLab project)

    By Administrator on 2012-12-10T13:07:41 (imported from GitLab)

Please register or sign in to reply