Skip to content
Snippets Groups Projects

fix gfm autocomplete for usernames

Merged fix gfm autocomplete for usernames
github/fork/jouve/fix_gfm_username_autocomplete into master
Merged gitlab-qa-bot requested to merge github/fork/jouve/fix_gfm_username_autocomplete into master

Created by: jouve

Since #2208 autocompletion for links to users in GFM is broken.

This fix replaces name by username for completion (name still displayed)

exemple: gfm_autocomplete.png

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Can you please remove the build failure "fix". @narkoz @vsizov autocomplete needs to access the User#username via the API. What needs to be considered? Docs? Tests? Maybe you can add it to the API first? @jouve could then update the PR to only fix the autocomplete

    By Administrator on 2012-12-10T22:17:49 (imported from GitLab project)

    By Administrator on 2012-12-10T22:17:49 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jouve

    @Riyad I moved the spec "fix" to its own PR (#2249) and made 2 commits of the original one. The first one is the update of the api and examples doc and the second is GFM fix.

    By Administrator on 2012-12-11T00:49:02 (imported from GitLab project)

    By Administrator on 2012-12-11T00:49:02 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: vsizov

    You should change version of API. Any thoughts?

    By Administrator on 2012-12-11T08:34:21 (imported from GitLab project)

    By Administrator on 2012-12-11T08:34:21 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: NARKOZ

    You should change version of API.

    Why?

    By Administrator on 2012-12-11T08:58:55 (imported from GitLab project)

    By Administrator on 2012-12-11T08:58:55 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: vsizov

    because parameter has been changed.

    By Administrator on 2012-12-11T09:03:59 (imported from GitLab project)

    By Administrator on 2012-12-11T09:03:59 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    @vsizov @narkoz We should change the API version for the 4.0 release. But not necessarily in this PR. ;)

    By Administrator on 2012-12-11T18:12:10 (imported from GitLab project)

    By Administrator on 2012-12-11T18:12:10 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Using @Member as a shortcut in setup is really nice. :)

    By Administrator on 2012-12-13T00:28:33 (imported from GitLab project)

    By Administrator on 2012-12-13T00:28:33 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Otherwise it looks good. :)

    By Administrator on 2012-12-13T00:33:30 (imported from GitLab project)

    By Administrator on 2012-12-13T00:33:30 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    @jouve Please update once more (annoying I know :wink:) so it can be merged. :)

    By Administrator on 2012-12-13T00:34:54 (imported from GitLab project)

    By Administrator on 2012-12-13T00:34:54 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: riyad

    Thanks :)

    By Administrator on 2012-12-14T21:56:14 (imported from GitLab project)

    By Administrator on 2012-12-14T21:56:14 (imported from GitLab)

Please register or sign in to reply