Fix and refactoring gfm_autocomplete
Created by: vsizov
- We are using username only for namespace functionality.
- Dunno why we need pagination functionality in member auto-complete. @Riyad we need discuss it.
Merge request reports
Activity
Created by: jouve
That was changed to username because name can have spaces which broke gfm (#1223 (closed)).
By Administrator on 2012-12-18T19:43:29 (imported from GitLab project)
By Administrator on 2012-12-18T19:43:29 (imported from GitLab)
Created by: riyad
- We use username for GFM because of names with spaces (see #1223 (closed)).
- We have pagination because we can't search for users with the API at the moment, so we get all users for auto completion - page by page, because we can't get all at once.
So
By Administrator on 2012-12-18T20:37:24 (imported from GitLab project)
By Administrator on 2012-12-18T20:37:24 (imported from GitLab)
Created by: vsizov
then we should create separate action in controller for this functionality. It will be more cleaner than now. Also we can change API. But this ugly js must be deleted anyway. I can handle this. Thanks.
By Administrator on 2012-12-18T20:51:22 (imported from GitLab project)
By Administrator on 2012-12-18T20:51:22 (imported from GitLab)
Created by: riyad
@vsizov a general way of searching/filtering would be great for the API, it would make this a lot simpler.
By Administrator on 2012-12-18T20:53:49 (imported from GitLab project)
By Administrator on 2012-12-18T20:53:49 (imported from GitLab)
Created by: vsizov
Take a look here https://github.com/gitlabhq/gitlabhq/blob/master/app/views/notes/_note.html.haml#L4 in comments we use name but in gfm username. This mismatching must be fixed. My proposition is to use username everywhere. Name may be used for profile. What do you think guys?
By Administrator on 2012-12-18T21:15:53 (imported from GitLab project)
By Administrator on 2012-12-18T21:15:53 (imported from GitLab)
Created by: riyad
@vsizov +1
By Administrator on 2012-12-18T21:55:37 (imported from GitLab project)
By Administrator on 2012-12-18T21:55:37 (imported from GitLab)
Created by: dzaporozhets
I prefer names over usernames. I created usernames only for one goal - namespace personal project. Sure usernames useful for social networks. But we build a self-hosted application for working. And i prefer to recognize my collegues by full name like "Valeriy Sizov" and not "vsizov"
By Administrator on 2012-12-19T10:36:19 (imported from GitLab project)
By Administrator on 2012-12-19T10:36:19 (imported from GitLab)
Created by: vsizov
In this case we should write in comment something like this - @Valeriy Sizov. Do you like that?
By Administrator on 2012-12-19T10:50:49 (imported from GitLab project)
By Administrator on 2012-12-19T10:50:49 (imported from GitLab)
Created by: jouve
I proposed #2206 that added a new syntax to cope with spaces in names (ex: @{Valery Sizov}) as an alternate of #2208 which was merged and replaced name by username.
By Administrator on 2012-12-19T10:57:28 (imported from GitLab project)
By Administrator on 2012-12-19T10:57:28 (imported from GitLab)
Created by: dzaporozhets
@vsizov You think changing application behaviour to fit parser is a better way?
By Administrator on 2012-12-19T11:16:27 (imported from GitLab project)
By Administrator on 2012-12-19T11:16:27 (imported from GitLab)
