Skip to content
Snippets Groups Projects

Text Templates for mail notification

Closed gitlab-qa-bot requested to merge github/fork/tbe/master into master

Created by: tbe

Fixed the syntax errors, travis throws two errors, one for missing content in mail, but looks like false positive. #934 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: nimf

    I suppose, you should squash these commits into one.

    By Administrator on 2013-01-17T12:09:00 (imported from GitLab project)

    By Administrator on 2013-01-17T12:09:00 (imported from GitLab)

  • Created by: tbe

    Still failing but i could not see why.

      1) Admin::Users GET /admin/users/new should send valid email to user with email & password
          Failure/Error: email.body.should have_content(user.email)
          expected there to be content "bigbang@mail.com" in ""
          # ./spec/requests/admin/admin_users_spec.rb:58:in `block (4 levels) in <top (required)>'
          # ./spec/requests/admin/admin_users_spec.rb:53:in `block (3 levels) in <top (required)>

    The body does contain the user.email, twice. One in the HTML part, one in the text part.

    By Administrator on 2013-01-22T11:39:20 (imported from GitLab project)

    By Administrator on 2013-01-22T11:39:20 (imported from GitLab)

  • Created by: tbe

    Any reason not merging or closing this request?

    By Administrator on 2013-01-28T12:38:07 (imported from GitLab project)

    By Administrator on 2013-01-28T12:38:07 (imported from GitLab)

  • Created by: dzaporozhets

    yeap. It still should be reviewed and tested. It will be merged/closed after. thank you for understanding

    By Administrator on 2013-01-31T10:37:58 (imported from GitLab project)

    By Administrator on 2013-01-31T10:37:58 (imported from GitLab)

  • Created by: tbe

    no problem, just wanted to know if there is anything to do on my side i missed.

    By Administrator on 2013-01-31T11:27:15 (imported from GitLab project)

    By Administrator on 2013-01-31T11:27:15 (imported from GitLab)

  • Created by: dzaporozhets

    manually merged. thank you

    By Administrator on 2013-02-28T14:43:48 (imported from GitLab project)

    By Administrator on 2013-02-28T14:43:48 (imported from GitLab)

Please register or sign in to reply
Loading