Skip to content
Snippets Groups Projects

Basic support for external issues tracker

Merged Basic support for external issues tracker
github/fork/Undev/link-to-issue-tracker into master
Merged gitlab-qa-bot requested to merge github/fork/Undev/link-to-issue-tracker into master

Created by: Andrew8xx8

Implementation of feature discussed there https://github.com/gitlabhq/gitlabhq/issues/97#issuecomment-9193798

Looks like this:

Screenshot-Admin area GitLab - Google Chrome

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
config/gitlab.yml.example
Unable to load the diff
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    we need default settings for this at config/initializers/1_settings.rb

    By Administrator on 2013-02-28T12:32:45 (imported from GitLab project)

    By Administrator on 2013-02-28T12:32:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 1dab19d0
    • app/models/project.rb
    93 96 scope :joined, ->(user) { where("namespace_id != ?", user.namespace_id) }
    94 97 scope :public_only, -> { where(public: true) }
    95 98
    99 enumerize :issues_tracker, :in => (Gitlab.config.issues_tracker.keys).append(:gitlab), :default => :gitlab
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      I suggest to use Gitlab.config variable instead of Settings. Like Gitlab.config.issue_tracker_keys with default value so it does not end up with undefined method keys for nil

      By Administrator on 2013-02-28T12:32:45 (imported from GitLab project)

      By Administrator on 2013-02-28T12:32:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    I tried to implement this advices.

    And I have a problem with tests. For the test environment I need to use some fake data that remote issue trackers, and this setting must be initialized before Project model to be loading. I need to use a better configuration support.

    For example configus supports inherited configuration for different environments.

    I can do a pull request with best configure support.

    By Administrator on 2013-02-14T07:06:47 (imported from GitLab project)

    By Administrator on 2013-02-14T07:06:47 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    UPD: I see that settingslogic gem supports environments. It's better to use it features.

    Please check out https://github.com/gitlabhq/gitlabhq/pull/2987

    By Administrator on 2013-02-14T07:45:29 (imported from GitLab project)

    By Administrator on 2013-02-14T07:45:29 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Yeap. I guess we merge #2987

    By Administrator on 2013-02-14T13:56:31 (imported from GitLab project)

    By Administrator on 2013-02-14T13:56:31 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    I added default values for setting.

    Also in #2987 I have made a mistake with default section name in YAML config that is fixes here.

    By Administrator on 2013-02-14T14:31:06 (imported from GitLab project)

    By Administrator on 2013-02-14T14:31:06 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @Andrew8xx8 I'm not sure why its defined as base in production and you set it as defaults for other env

    By Administrator on 2013-02-14T14:37:18 (imported from GitLab project)

    By Administrator on 2013-02-14T14:37:18 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    Sorry, my fault. Maybe I'm mixed up with my file gitlab.yml

    By Administrator on 2013-02-14T14:45:06 (imported from GitLab project)

    By Administrator on 2013-02-14T14:45:06 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Basically this PR do next:

    1. add ability to specify external issue tracker
    2. patch gitlab markdown to render #123 as link to this external tracker

    @Andrew8xx8 am I right?

    By Administrator on 2013-02-14T16:10:10 (imported from GitLab project)

    By Administrator on 2013-02-14T16:10:10 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Few suggestion from usability:

    1. I guess when you select redmine for example we need to hide issues tab or redirect it to external tracker
    2. When I select redmine - it should enable text field with js so I can put project id without page reloading
    3. It should show Issue tracker selectbox only if more then one tracker exists

    By Administrator on 2013-02-14T16:14:47 (imported from GitLab project)

    By Administrator on 2013-02-14T16:14:47 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    Usability improved

    By Administrator on 2013-02-19T19:04:16 (imported from GitLab project)

    By Administrator on 2013-02-19T19:04:16 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Thank you. I will test it tomorrow and merge if ok

    By Administrator on 2013-02-20T10:50:20 (imported from GitLab project)

    By Administrator on 2013-02-20T10:50:20 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    5 days have passed and there is still no answer

    By Administrator on 2013-02-25T10:07:21 (imported from GitLab project)

    By Administrator on 2013-02-25T10:07:21 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    Can't be automatically merged.

    By Administrator on 2013-02-27T19:25:17 (imported from GitLab project)

    By Administrator on 2013-02-27T19:25:17 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @Andrew8xx8 I am busy but I remember of it. Have some patience please

    By Administrator on 2013-02-28T07:28:14 (imported from GitLab project)

    By Administrator on 2013-02-28T07:28:14 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    thank you

    By Administrator on 2013-02-28T15:11:36 (imported from GitLab project)

    By Administrator on 2013-02-28T15:11:36 (imported from GitLab)

    • Please register or sign in to reply