Skip to content
Snippets Groups Projects

System hooks code & logic refactoring

Merged gitlab-qa-bot requested to merge github/fork/Undev/system-hook-observer-improves into master

Created by: Andrew8xx8

We must stop to place logic in observers. It's not scalable, clean and also this code is hard to testing.

Let's go to include Service Layer.

Good resources about Service Layer:

http://collectiveidea.com/blog/archives/2012/06/28/wheres-your-business-logic/

http://blog.firsthand.ca/2011/10/rails-is-not-your-application.html

http://blog.carbonfive.com/2012/01/10/does-my-rails-app-need-a-service-layer/

Merge request reports

Merged by avatar (Mar 7, 2025 9:14pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: dzaporozhets

    It makes sense. +1 for Service Layer

    By Administrator on 2013-02-25T18:15:20 (imported from GitLab project)

    By Administrator on 2013-02-25T18:15:20 (imported from GitLab)

Please register or sign in to reply
Loading