Skip to content

System hooks code & logic refactoring

gitlab-qa-bot requested to merge github/fork/Undev/system-hook-observer-improves into master

Created by: Andrew8xx8

We must stop to place logic in observers. It's not scalable, clean and also this code is hard to testing.

Let's go to include Service Layer.

Good resources about Service Layer:

http://collectiveidea.com/blog/archives/2012/06/28/wheres-your-business-logic/

http://blog.firsthand.ca/2011/10/rails-is-not-your-application.html

http://blog.carbonfive.com/2012/01/10/does-my-rails-app-need-a-service-layer/

Merge request reports