Skip to content
Snippets Groups Projects

Improve network graph

Merged gitlab-qa-bot requested to merge github/fork/hiroponz/improve-network-graph into master

Created by: hiroponz

Before

  • The commits is not ordered by commiter date.
  • Not detecting an overlap of a line in some cases.

network_graph_before

After

network_graph_after

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: dzaporozhets

    nice. Can you also add some tests for Graph models please?

    By Administrator on 2013-02-28T07:15:13 (imported from GitLab project)

    By Administrator on 2013-02-28T07:15:13 (imported from GitLab)

  • Created by: hiroponz

    Sorry, but it may be difficult to add some tests, since the knowledge about rails test is insufficient. Although time may be taken, I investigate anyhow.

    By Administrator on 2013-02-28T08:46:33 (imported from GitLab project)

    By Administrator on 2013-02-28T08:46:33 (imported from GitLab)

  • Created by: dzaporozhets

    @hiroponz thank you. Since it does not covered with tests I'm a bit of afraid to broke something. And since you done a lot with Graph you are only one who know how this code works and can write proper tests

    By Administrator on 2013-02-28T09:41:24 (imported from GitLab project)

    By Administrator on 2013-02-28T09:41:24 (imported from GitLab)

  • Created by: hiroponz

    @randx I have added two senarioes.

    1. switch ref to "stable".
    2. look for a commit by SHA of "v2.1.0".

    By Administrator on 2013-03-04T09:29:50 (imported from GitLab project)

    By Administrator on 2013-03-04T09:29:50 (imported from GitLab)

  • Created by: dzaporozhets

    @hiroponz thank you

    By Administrator on 2013-03-05T07:02:05 (imported from GitLab project)

    By Administrator on 2013-03-05T07:02:05 (imported from GitLab)

Please register or sign in to reply
Loading