Skip to content

Fix error handling of missing new_issue_url config in url_for_new_issue.

gitlab-qa-bot requested to merge github/fork/jrmithdobbs/fix_missing_error_handling-url_for_new_issue into master

Created by: jrmithdobbs

Found this while digging into test failures in the vagrant environment. gitlabhq/gitlab-vagrant-vm#40

This changes that error from:

1) IssuesHelper url_for_new_issue should return path to external tracker
     Failure/Error: url_for_new_issue.should match(ext_expected)
     NoMethodError:
       undefined method `gsub' for nil:NilClass
     # ./app/helpers/issues_helper.rb:64:in `url_for_new_issue'
     # ./spec/helpers/issues_helper_spec.rb:96:in `block (3 levels) in <top (required)>'

to:

  1) IssuesHelper url_for_new_issue should return path to external tracker
     Failure/Error: let(:issues_url) { Gitlab.config.issues_tracker.redmine.new_issue_url}
     Settingslogic::MissingSetting:
       Missing setting 'new_issue_url' in 'redmine' section in 'issues_tracker' section in /home/vagrant/gitlabhq/config/gitlab.yml
     # ./spec/helpers/issues_helper_spec.rb:81:in `block (3 levels) in <top (required)>'
     # ./spec/helpers/issues_helper_spec.rb:83:in `block (3 levels) in <top (required)>'
     # ./spec/helpers/issues_helper_spec.rb:96:in `block (3 levels) in <top (required)>'

Which is much more helpful in figuring out that there's a config problem. :)

Merge request reports