Skip to content
Snippets Groups Projects

Implemented code search feature

Closed Implemented code search feature
github/fork/jacargentina/feature-search into master
Closed gitlab-qa-bot requested to merge github/fork/jacargentina/feature-search into master

Created by: jacargentina

/cc @randx

I've forked grit to achieve this. Also it is my first contribution to a ruby app, so please be kind.

If somebody can look at it and create the needed tests, i would love to help fixing any problem found on the code.

Hope this can be merged soon (code search is a must on gitlab!)

Cheers!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    Umergeable - please rebase!

    By Administrator on 2013-04-12T14:51:03 (imported from GitLab project)

    By Administrator on 2013-04-12T14:51:03 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage decreased (-36.03%) when pulling c5cbcdbd on jacargentina:feature-search into 63b78a39 on gitlabhq:master.

    View Details

    By Administrator on 2013-04-12T16:35:12 (imported from GitLab project)

    By Administrator on 2013-04-12T16:35:12 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacargentina

    I think i did my first github rebase!

    Again, please be kind. The travis failed but was not because of merging but tests failing, right?

    Cheers!

    By Administrator on 2013-04-12T16:52:28 (imported from GitLab project)

    By Administrator on 2013-04-12T16:52:28 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: lbt

    I didn't spot a config option. We have a lot of large projects (Qt, Webkit, kernels etc) and I would like to be able to disable file search - the current implementation looks like it uses : repository.repo.grep(query, default_branch) and I worry that it would impact performance.

    By Administrator on 2013-04-13T16:48:23 (imported from GitLab project)

    By Administrator on 2013-04-13T16:48:23 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacargentina

    Yes, adding some config option is a must. I dont know how to handle options yet on a Rails app.

    Any body can help me with this?

    By Administrator on 2013-04-13T17:23:48 (imported from GitLab project)

    By Administrator on 2013-04-13T17:23:48 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    @jacargentina The rebasing not seems to be worked. Your pull request should only contain your own commits!

    By Administrator on 2013-04-14T14:59:54 (imported from GitLab project)

    By Administrator on 2013-04-14T14:59:54 (imported from GitLab)

Please register or sign in to reply