[BUGFIX] User suggest at team_members/new not working with relative_url_root

Created by: simonswine

This should fix the non working auto-suggestion, when adding a new team member on a relative_url_root setup. This bug exists also in 5.0 and 5.1.

Created by: coveralls

Coverage decreased (-0.08%) when pulling 05ec5720a21be3ae17cfb93accc8e8bc2bf2e530 on former03:feature_bugfix_js_memberadd_realtive_url_root into 75fbdc40 on gitlabhq:master.

By Administrator on 2013-04-24T07:57:51 (imported from GitLab project)

By Administrator on 2013-04-24T07:57:51 (imported from GitLab)

Created by: senny

you can use if gon.relative_url_root.present?.

By Administrator on 2013-04-24T17:42:18 (imported from GitLab project)

By Administrator on 2013-04-24T17:42:18 (imported from GitLab)

Created by: senny

can you remove this blank line change?

By Administrator on 2013-04-24T17:42:18 (imported from GitLab project)

By Administrator on 2013-04-24T17:42:18 (imported from GitLab)

Created by: senny

thanks for your contribution, I added some minor comments.

By Administrator on 2013-04-24T11:20:55 (imported from GitLab project)

By Administrator on 2013-04-24T11:20:55 (imported from GitLab)

Created by: simonswine

@senny: Thanks for your comments fixed it now, i was in a bit of hurry this morning...

By Administrator on 2013-04-24T14:24:33 (imported from GitLab project)

By Administrator on 2013-04-24T14:24:33 (imported from GitLab)

Created by: senny

no problem, thanks for your work . Is there a corresponding issue open on the tracker that this would fix or is it only this PR?

looks good to me.

/cc @randx

By Administrator on 2013-04-24T14:27:12 (imported from GitLab project)

By Administrator on 2013-04-24T14:27:12 (imported from GitLab)

Created by: coveralls

Coverage decreased (-0.08%) when pulling 3c9d6f62d21ad87bc0995d788e60b853002f9e33 on former03:feature_bugfix_js_memberadd_realtive_url_root into 75fbdc40 on gitlabhq:master.

By Administrator on 2013-04-24T14:49:10 (imported from GitLab project)

By Administrator on 2013-04-24T14:49:10 (imported from GitLab)

Created by: simonswine

After searching a bit i think #3540 (closed) should be fixed by this PR...

By Administrator on 2013-04-24T14:53:55 (imported from GitLab project)

By Administrator on 2013-04-24T14:53:55 (imported from GitLab)

Created by: senny

great, thanks for digging. Can you add "Closing #3540 (closed)" to the commit message (you don't need to put it on the first line if the message is already long). Also can you squash the two commits together?

By Administrator on 2013-04-24T14:58:29 (imported from GitLab project)

By Administrator on 2013-04-24T14:58:29 (imported from GitLab)

Created by: simonswine

done

By Administrator on 2013-04-24T17:46:44 (imported from GitLab project)

By Administrator on 2013-04-24T17:46:44 (imported from GitLab)

Created by: coveralls

Coverage decreased (-12.26%) when pulling 529376bb on former03:feature_bugfix_js_memberadd_realtive_url_root into 75fbdc40 on gitlabhq:master.

By Administrator on 2013-04-24T18:04:56 (imported from GitLab project)

By Administrator on 2013-04-24T18:04:56 (imported from GitLab)

Created by: dzaporozhets

Have you tested it for non-relative instance? Is it safe to merge?

By Administrator on 2013-04-26T17:25:11 (imported from GitLab project)

By Administrator on 2013-04-26T17:25:11 (imported from GitLab)

Created by: simonswine

Here in my vagrant machine without relative_root it runs perfectly. So yes and yes

By Administrator on 2013-04-26T19:11:51 (imported from GitLab project)

By Administrator on 2013-04-26T19:11:51 (imported from GitLab)

Created by: amadanmath

+1 to @melvin's comment: gon.relative_url_root? works, gon.relative_url_root.present? does not.

By Administrator on 2013-06-12T02:41:55 (imported from GitLab project)

By Administrator on 2013-06-12T02:41:55 (imported from GitLab)

Created by: mkasztelnik

+1 to @Melwin and @amadanmath comments: gon.relative_url_root.present? does not work. Another alternative is !!gon.relative_url_root (tested on 5.3)

By Administrator on 2013-06-27T22:08:22 (imported from GitLab project)

By Administrator on 2013-06-27T22:08:22 (imported from GitLab)