Skip to content
Snippets Groups Projects

Default settings for project features

Merged Default settings for project features
github/fork/Undev/default_project_settings into master
Merged gitlab-qa-bot requested to merge github/fork/Undev/default_project_settings into master

Created by: Andrew8xx8

I think that it's a good idea to move default settings for project features in config.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-12.25%) when pulling 7907bc81 on Undev:default_project_settings into 75fbdc40 on gitlabhq:master.

    By Administrator on 2013-04-24T12:20:12 (imported from GitLab project)

    By Administrator on 2013-04-24T12:20:12 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    could you add a test-case to verify the behavior? Also it would be good to squash the commits into a single one.

    By Administrator on 2013-04-24T12:24:55 (imported from GitLab project)

    By Administrator on 2013-04-24T12:24:55 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Andrew8xx8

    What kind of test-case you want to see?

    By Administrator on 2013-04-24T12:44:37 (imported from GitLab project)

    By Administrator on 2013-04-24T12:44:37 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    I don't have a good understanding of the code but I feel like such features should have coverage. Let's wait for @randx to join and hear his opinion.

    By Administrator on 2013-04-24T12:58:00 (imported from GitLab project)

    By Administrator on 2013-04-24T12:58:00 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: AlexDenisov

    @Andrew8xx8, all this cases already described by database schema. See this line and below.

    By Administrator on 2013-04-24T16:48:06 (imported from GitLab project)

    By Administrator on 2013-04-24T16:48:06 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: zzet

    @AlexDenisov how do you think, better to change db schema or update config file?

    By Administrator on 2013-04-24T21:49:47 (imported from GitLab project)

    By Administrator on 2013-04-24T21:49:47 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: AlexDenisov

    @zzet, oh, I realize. That's my fault, never mind.

    By Administrator on 2013-04-25T03:17:44 (imported from GitLab project)

    By Administrator on 2013-04-25T03:17:44 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit f5b549af
config/gitlab.yml.example
37 37 # signup_enabled: true # default: false - Account passwords are not sent via the email if signup is enabled.
38 38 # username_changing_enabled: false # default: true - User can change her username/namespace
39 39
40 ## Default project features settings
41 default_projects_features:
42 issues: true
43 merge_requests: true
44 wiki: true
45 wall: false
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    Wall and snippets are disabled by default now. Can you save a behavior please?

    By Administrator on 2013-04-26T08:02:19 (imported from GitLab project)

    By Administrator on 2013-04-26T08:02:19 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit f5b549af
    • config/initializers/1_settings.rb
    60 60 Settings.gitlab['user'] ||= 'git'
    61 61 Settings.gitlab['signup_enabled'] ||= false
    62 62 Settings.gitlab['username_changing_enabled'] = true if Settings.gitlab['username_changing_enabled'].nil?
    63 Settings.gitlab['default_projects_features'] ||= {}
    64 Settings.gitlab.default_projects_features['issues'] = true if Settings.gitlab.default_projects_features['issues'].nil?
    65 Settings.gitlab.default_projects_features['merge_requests'] = true if Settings.gitlab.default_projects_features['merge_requests'].nil?
    66 Settings.gitlab.default_projects_features['wiki'] = true if Settings.gitlab.default_projects_features['wiki'].nil?
    67 Settings.gitlab.default_projects_features['wall'] = false if Settings.gitlab.default_projects_features['wall'].nil?
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      same here

      By Administrator on 2013-04-26T08:02:19 (imported from GitLab project)

      By Administrator on 2013-04-26T08:02:19 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage increased (+0.04%) when pulling f5b549af on Undev:default_project_settings into 75fbdc40 on gitlabhq:master.

    By Administrator on 2013-04-26T11:24:13 (imported from GitLab project)

    By Administrator on 2013-04-26T11:24:13 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    @Andrew8xx8 thank you

    By Administrator on 2013-04-26T08:19:46 (imported from GitLab project)

    By Administrator on 2013-04-26T08:19:46 (imported from GitLab)

    • Please register or sign in to reply