Skip to content
Snippets Groups Projects

improve gfm autocomplete

Merged gitlab-qa-bot requested to merge github/fork/ichord/gfm-autocomp into master

Created by: ichord

Hi, I'm the project owner of jquery-atwho-rails ( At.js ) I have found that gfm autcomplete in gitlab's demo site was very slow. It's posting Ajax request every times while At.js catch the username. I have read all issues related to it, and found it's my bad that this plugin is not good enough. And it seems no one want to tell me about it. so i gonna to do it on my own.

Here is the improvement:

  • autocomplete issues
  • preload all data ( emojis, issues, members) when inputor (textarea, input) on focus.
  • can search by issues's title and id
  • can search by member's username and name
  • Show popup while preceding by space or is new line. #3786

One more thing, welcome any suggestions. Thanks. :smiley:

Commits log

  • update jquery-atwho-rails to v0.3.0
  • autocomplete issues and preload the data.
  • add autocomplete_source action to project for gfm autocomplete
  • move init_autocomplete layout from head_panel to project_resource

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: coveralls

    Coverage Status

    Coverage decreased (-12.42%) when pulling 439cd3eb on ichord:gfm-autocomp into ca244c35 on gitlabhq:master.

    By Administrator on 2013-05-04T04:20:38 (imported from GitLab project)

    By Administrator on 2013-05-04T04:20:38 (imported from GitLab)

  • Created by: dzaporozhets

    Hi @ichord! Thank you for submitted PR. Its awesome! :heart:

    By Administrator on 2013-05-08T11:18:12 (imported from GitLab project)

    By Administrator on 2013-05-08T11:18:12 (imported from GitLab)

  • Created by: ichord

    @randx :smiley: my pleasure. ;)

    By Administrator on 2013-05-08T16:15:23 (imported from GitLab project)

    By Administrator on 2013-05-08T16:15:23 (imported from GitLab)

  • Created by: hiroponz

    @ichord It's great! Auto-complete have became very first.

    BTW, it is very useful when reporting bug or explaining new feature if "attach images by dragging & dropping" would be enable like GitHub :)

    By Administrator on 2013-05-09T00:38:07 (imported from GitLab project)

    By Administrator on 2013-05-09T00:38:07 (imported from GitLab)

Please register or sign in to reply
Loading