Notify email to mentioned users; show participants ala github on issuables
Created by: jacargentina
This implements http://feedback.gitlab.com/forums/176466-general/suggestions/3726309-email-notify-user-when-they-are-mentioned-anywher
Also adds rendering of issuables participants ala github.
Merge request reports
Activity
Created by: coveralls
Coverage decreased (-0%) when pulling 9bc39efbe035c7aacd0b402305028c6bc889f58e on jacargentina:notifymentioned into 6e1ee1fe on gitlabhq:master.
By Administrator on 2013-05-10T02:46:15 (imported from GitLab project)
By Administrator on 2013-05-10T02:46:15 (imported from GitLab)
Created by: YenZi
I am really looking forward to see this feature added (see my feature request : http://feedback.gitlab.com/forums/176466-general/suggestions/3922228-opt-into-and-out-of-notifications-for-specific-iss ) Now I am curious: Will this change send an email only once, when a user is newly mentioned in a discussion or will he be notified about all changes in the discussion after he had mentioned once ? (Hoping for the latter one ;-) )
By Administrator on 2013-05-10T11:55:35 (imported from GitLab project)
By Administrator on 2013-05-10T11:55:35 (imported from GitLab)
Created by: coveralls
Coverage decreased (-0%) when pulling 1e0eababe4691f5cca64f1b90806c00dfb9fe617 on jacargentina:notifymentioned into 6e1ee1fe on gitlabhq:master.
By Administrator on 2013-05-10T11:58:19 (imported from GitLab project)
By Administrator on 2013-05-10T11:58:19 (imported from GitLab)
Created by: jacargentina
By now, only when newly mentioned. But with some discussion we can change that?
Maybe this code can later be extended to reach the point where any issue will get the list of people participating, ala github.
By Administrator on 2013-05-10T12:03:22 (imported from GitLab project)
By Administrator on 2013-05-10T12:03:22 (imported from GitLab)
Created by: coveralls
Coverage decreased (-0%) when pulling 39f458aee1c11ab28525712c843d8e4214ad51ae on jacargentina:notifymentioned into 6e1ee1fe on gitlabhq:master.
By Administrator on 2013-05-10T23:37:51 (imported from GitLab project)
By Administrator on 2013-05-10T23:37:51 (imported from GitLab)
Created by: coveralls
Coverage remained the same when pulling e5037cc3479d0fb52fd9aacc4523096139204f44 on jacargentina:notifymentioned into 6e1ee1fe on gitlabhq:master.
By Administrator on 2013-05-11T05:08:29 (imported from GitLab project)
By Administrator on 2013-05-11T05:08:29 (imported from GitLab)
Created by: coveralls
Coverage decreased (-0%) when pulling b4703fb9c65333a0ee66a4a10ebe21c7b9fa2fbf on jacargentina:notifymentioned into 6e1ee1fe on gitlabhq:master.
By Administrator on 2013-05-11T05:40:53 (imported from GitLab project)
By Administrator on 2013-05-11T05:40:53 (imported from GitLab)
Created by: bbodenmiller
@jacargentina I think the devs will probably ask you to squash your commits. I'd also like to see @YenZi feature request added but this is definitely a start in the right direction.
By Administrator on 2013-05-13T07:51:55 (imported from GitLab project)
By Administrator on 2013-05-13T07:51:55 (imported from GitLab)
Created by: coveralls
Coverage decreased (-0%) when pulling 097bab5248771f19df26d19658fc3c9dd41a8761 on jacargentina:notifymentioned into 9ea27db1 on gitlabhq:master.
By Administrator on 2013-05-13T16:12:03 (imported from GitLab project)
By Administrator on 2013-05-13T16:12:03 (imported from GitLab)
Created by: jacargentina
@bbodenmiller It is refactored now to always notify to all participating users. Also did a little touch on the CSS styling to give a little margin below the participaing users list.
I would love if @randx can give a look?
By Administrator on 2013-05-13T18:27:19 (imported from GitLab project)
By Administrator on 2013-05-13T18:27:19 (imported from GitLab)
Created by: coveralls
Coverage decreased (-0%) when pulling 62129a29e8e506d190c35f30f3df0b6d4113be67 on jacargentina:notifymentioned into c5feabde on gitlabhq:master.
By Administrator on 2013-05-13T18:56:12 (imported from GitLab project)
By Administrator on 2013-05-13T18:56:12 (imported from GitLab)
Created by: YenZi
By Administrator on 2013-05-14T06:56:41 (imported from GitLab project)
By Administrator on 2013-05-14T06:56:41 (imported from GitLab)
Created by: bbodenmiller
I haven't had a chance to try this commit specifically but it sounds great. Does this still allow a user to unsubscribe from the thread if desired ala GitHub? What happeneds if they unsubscribe and then are mentioned again? (How does GitHub handle that) I imagine the devs will want some ci tests before they can merge this.
By Administrator on 2013-05-14T10:40:43 (imported from GitLab project)
By Administrator on 2013-05-14T10:40:43 (imported from GitLab)
Created by: jacargentina
@bbodenmiller The mechanism for "not notifyng a user" have'nt changed.
I would love some help to write ci tests, and also for change make anything of this really better for merging into master. I can give push permissions on my repo if anybody can help me.
By Administrator on 2013-05-14T11:13:22 (imported from GitLab project)
By Administrator on 2013-05-14T11:13:22 (imported from GitLab)
Created by: YenZi
Hey, what happened to this great feature ? No update since your request for helping with ci tests. I guess it didn't make it into 5.2 ? :-(
By Administrator on 2013-05-22T08:56:12 (imported from GitLab project)
By Administrator on 2013-05-22T08:56:12 (imported from GitLab)
Created by: YenZi
Since I didn't get any feedback on my question (except for "tumbs up" from other users waiting for this feature as well), I thought I might ask once more : Any chance we see this great feature in the upcoming 5.3 ? Is there any blocker ?
By Administrator on 2013-06-14T07:51:56 (imported from GitLab project)
By Administrator on 2013-06-14T07:51:56 (imported from GitLab)
Created by: Philzen
@YenZi wrote:
Any chance we see this great feature in the upcoming 5.3 ? Is there any blocker ?
@randx, @bbodenmiller, @Riyad, any core team guys - can u comment? People (including myself) would welcome this feature very much :)
By Administrator on 2013-06-14T12:28:44 (imported from GitLab project)
By Administrator on 2013-06-14T12:28:44 (imported from GitLab)
Created by: bbodenmiller
Can we get this reviewed so we can close http://feedback.gitlab.com/forums/176466-general/suggestions/3726309-email-notify-user-when-they-are-mentioned-anywher?
/cc @randx @senny @dosire
By Administrator on 2013-06-18T09:20:11 (imported from GitLab project)
By Administrator on 2013-06-18T09:20:11 (imported from GitLab)
Created by: forki
Is this only working for issues? We just upgraded to 5.4 and it seems it doesn't work on commits.
Just double checked: It works on issues for us. But not on commits.
By Administrator on 2013-07-22T10:20:05 (imported from GitLab project)
By Administrator on 2013-07-22T10:20:05 (imported from GitLab)
Created by: forki
May I ask why?
See also http://feedback.gitlab.com/forums/176466-general/suggestions/4132803-notify-username-from-comments
By Administrator on 2013-07-22T11:00:09 (imported from GitLab project)
By Administrator on 2013-07-22T11:00:09 (imported from GitLab)
Created by: Razer6
@forki you're right. As the PR Description also supposes it should wor since it says anywhere. I'm not a ruby guy (not yet) so @jacargentina can you clarifify if this should work?
If not we should reopen the ticket on the feature tracker..
By Administrator on 2013-07-22T11:13:40 (imported from GitLab project)
By Administrator on 2013-07-22T11:13:40 (imported from GitLab)
Created by: jacargentina
Looking at the code again, it seems it is not ready for notification on commit notes.
I'm looking at it, so maybe i' ll post a MR for adding that support on current master.
By Administrator on 2013-07-22T16:58:42 (imported from GitLab project)
By Administrator on 2013-07-22T16:58:42 (imported from GitLab)
Created by: YenZi
Thanks a lot for this feature ! It is extremely helpful for us to get issues and communication organized better. There is a small enhancement I would like to suggest (don't want to open a new feature request for this though ;-) ) If possible, it would be great to have a little tooltip when hovering over the avatars of the participants. We have some people here who refuse to use gravatar.com (which I can understand). So there are a lot of just grey default avatars. I know that you can click on the avatar to jump to the users profile page. But that's a bit cumbersome and simply to much info. Just the username in a tooltip would be absolutely sufficient.
By Administrator on 2013-07-23T17:29:02 (imported from GitLab project)
By Administrator on 2013-07-23T17:29:02 (imported from GitLab)
Created by: forki
@jacargentina I think https://github.com/gitlabhq/gitlabhq/issues/4689 relates to this issue here in some way.
By Administrator on 2013-08-01T14:55:40 (imported from GitLab project)
By Administrator on 2013-08-01T14:55:40 (imported from GitLab)
Created by: jacargentina
@forki : as i see it, it is not related to this.
Problem is on this file i think:
/app/views/notify/_note_message.html.haml
The markdown(@note.note) part renders links without the http:// part.... as if it would be always rendered on a browser navigating the commit/issue, etc.
@randx, maybe u can look at this?
By Administrator on 2013-08-01T19:04:23 (imported from GitLab project)
By Administrator on 2013-08-01T19:04:23 (imported from GitLab)
