Skip to content
Snippets Groups Projects

Issue 3599: Add snippets_enabled flag to projects for API

Merged Issue 3599: Add snippets_enabled flag to projects for API
github/fork/dblessing/3599 into master
Merged gitlab-qa-bot requested to merge github/fork/dblessing/3599 into master

Created by: dblessing

Fixes #3599 (closed).

I have tested this for both creation and retrieval via API and it all works as described. I applied these changes and tested on a master branch build.

Please see previous pull request at #3989 for discussion regarding the comments. I had some issues with the squash and ended up having to close that PR in favor of this one. Thanks.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    Please can you also describe this new feature in the API docs?

    By Administrator on 2013-05-19T18:52:35 (imported from GitLab project)

    By Administrator on 2013-05-19T18:52:35 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling fb04cdd276bf90d512b6996f26ca5b0f47b0ef1c on bke-drewb:3599 into 6cf29166 on gitlabhq:master.

    By Administrator on 2013-05-19T18:58:46 (imported from GitLab project)

    By Administrator on 2013-05-19T18:58:46 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dblessing

    Docs updated. Do I need to squash again? Is the only way to squash to close this PR, delete my branch, squash and open a new PR?

    By Administrator on 2013-05-19T21:39:13 (imported from GitLab project)

    By Administrator on 2013-05-19T21:39:13 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling f8d361841e13760f18d72ff3bab1d5bfe8de58ff on bke-drewb:3599 into 6cf29166 on gitlabhq:master.

    By Administrator on 2013-05-19T21:43:12 (imported from GitLab project)

    By Administrator on 2013-05-19T21:43:12 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    Thank you! No it should be possible to do this without making a new PR. I think you can squash locally and do a forced push to Github.

    By Administrator on 2013-05-19T21:42:54 (imported from GitLab project)

    By Administrator on 2013-05-19T21:42:54 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dblessing

    Hey, would you look at that. Thanks for the tip.

    By Administrator on 2013-05-19T21:46:18 (imported from GitLab project)

    By Administrator on 2013-05-19T21:46:18 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling a133eece5e71b311e5c2a7eb13dd3bb29d28f929 on bke-drewb:3599 into 6cf29166 on gitlabhq:master.

    By Administrator on 2013-05-19T22:02:17 (imported from GitLab project)

    By Administrator on 2013-05-19T22:02:17 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    @randx Can you take a look?

    By Administrator on 2013-05-20T08:39:52 (imported from GitLab project)

    By Administrator on 2013-05-20T08:39:52 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: NARKOZ

    LGTM

    By Administrator on 2013-05-20T11:14:00 (imported from GitLab project)

    By Administrator on 2013-05-20T11:14:00 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    can you please make it mergeable?

    By Administrator on 2013-06-11T13:54:26 (imported from GitLab project)

    By Administrator on 2013-06-11T13:54:26 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dblessing

    @randx I think that make it mergeable. Thanks for looking at this.

    By Administrator on 2013-06-12T02:39:07 (imported from GitLab project)

    By Administrator on 2013-06-12T02:39:07 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 31b06ebd on bke-drewb:3599 into 964f7a11 on gitlabhq:master.

    By Administrator on 2013-06-12T02:56:38 (imported from GitLab project)

    By Administrator on 2013-06-12T02:56:38 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 31b06ebd on bke-drewb:3599 into 964f7a11 on gitlabhq:master.

    By Administrator on 2013-06-12T02:53:43 (imported from GitLab project)

    By Administrator on 2013-06-12T02:53:43 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 31b06ebd on bke-drewb:3599 into 964f7a11 on gitlabhq:master.

    By Administrator on 2013-06-12T03:05:25 (imported from GitLab project)

    By Administrator on 2013-06-12T03:05:25 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    @randx this is mergable now, can you take another look?

    By Administrator on 2013-06-13T15:05:41 (imported from GitLab project)

    By Administrator on 2013-06-13T15:05:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: Razer6

    @bke-drewb Can you add default settings like https://github.com/gitlabhq/gitlabhq/blob/master/app/contexts/projects/create_context.rb#L14 does? The config file already has default settings.

    By Administrator on 2013-07-07T09:12:20 (imported from GitLab project)

    By Administrator on 2013-07-07T09:12:20 (imported from GitLab)

Please register or sign in to reply