This makes gitlabhq compatible with more LDAP servers (specifically OpenLDAP).

Created by: steveprentice

This helps with compatibility with more LDAP providers as the implementation doesn't depend on the exact names of the LDAP fields. The LDAP strategy helps maps the attributes to the fields in the info object and we use the info object to get the email and name.

This makes the LDAP auth compatible with most OpenLDAP servers as well.

Created by: vsizov

are you sure in your code. It tested?

By Administrator on 2012-02-17T19:47:45 (imported from GitLab project)

By Administrator on 2012-02-17T19:47:45 (imported from GitLab)

Created by: steveprentice

Yes. Tested against an OpenLDAP server and an Active Directory server. Works on both. Previously, authenticating against our internal OpenLDAP server was failing because our ldap entries don't have the sAMAccountName attribute defined causing an exception at user.rb:71.

Getting these attributes is abstracted by the omniauth-ldap strategy to simplify supporting more LDAP servers. In omniauth/strategies/ldap.rb, look at how it maps the attributes to the info object with the @@config map and map_user().

https://github.com/intridea/omniauth-ldap/blob/master/lib/omniauth/strategies/ldap.rb

By Administrator on 2012-02-17T20:35:56 (imported from GitLab project)

By Administrator on 2012-02-17T20:35:56 (imported from GitLab)

Created by: dzaporozhets

@vsizov you did ldap - merge it if ok

By Administrator on 2012-02-19T09:36:07 (imported from GitLab project)

By Administrator on 2012-02-19T09:36:07 (imported from GitLab)