Skip to content
Snippets Groups Projects

Scrum view style milestone view.

Merged Scrum view style milestone view.
github/fork/dosire/scrum-view-for-milestone into master
Merged gitlab-qa-bot requested to merge github/fork/dosire/scrum-view-for-milestone into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
app/views/milestones/_issues.html.haml 0 → 100644
1 .span6
2 .ui-box.milestone-issue-filter
3 %h5.title= title
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    I suggest to replace .title block with one line like

      %h5.title= issues.first

    By Administrator on 2013-06-14T12:13:33 (imported from GitLab project)

    By Administrator on 2013-06-14T12:13:33 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit f7ea649f
    • app/views/milestones/show.html.haml
    57 57
    58 58 .row
    59 .span6
    60 .ui-box.milestone-issue-filter
    61 .title
    62 %ul.nav.nav-pills
    63 %li.active= link_to('Open Issues', '#')
    64 %li=link_to('All Issues', '#')
    65 %ul.well-list
    66 - @issues.each do |issue|
    67 %li{data: {closed: issue.closed?}}
    68 = link_to [@project, issue] do
    69 %span.badge.badge-info ##{issue.id}
    70 –
    71 = link_to_gfm truncate(issue.title, length: 60), [@project, issue]
    59 = render(partial: 'issues', locals: {title: 'Unstarted Issues (open and unassigned)', issues: @issues.opened.unassigned})
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      use named variables. Ex.

        = render 'issues', title: 'Unstarted Issues (open and unassigned)', issues: @issues.opened.unassigned

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab project)

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 6637c1e4 on dosire:scrum-view-for-milestone into 1b49ae2e on gitlabhq:master.

    By Administrator on 2013-06-12T08:17:37 (imported from GitLab project)

    By Administrator on 2013-06-12T08:17:37 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit f7ea649f
    • app/models/issue.rb
    28 28 scope :cared, ->(user) { where(assignee_id: user) }
    29 29 scope :authored, ->(user) { where(author_id: user) }
    30 30 scope :open_for, ->(user) { opened.assigned(user) }
    31 scope :assigned, -> { where("assignee_id IS NOT NULL") }
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      please use lambda. like -> { where("assignee_id IS NOT NULL") }

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab project)

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit f7ea649f
    • app/views/milestones/show.html.haml
    57 57
    58 58 .row
    59 .span6
    60 .ui-box.milestone-issue-filter
    61 .title
    62 %ul.nav.nav-pills
    63 %li.active= link_to('Open Issues', '#')
    64 %li=link_to('All Issues', '#')
    65 %ul.well-list
    66 - @issues.each do |issue|
    67 %li{data: {closed: issue.closed?}}
    68 = link_to [@project, issue] do
    69 %span.badge.badge-info ##{issue.id}
    70 –
    71 = link_to_gfm truncate(issue.title, length: 60), [@project, issue]
    59 = render(partial: 'issues', locals: {title: 'Unstarted Issues (open and unassigned)', issues: @issues.opened.unassigned})
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dzaporozhets

      use ruby 1.9 hash syntax please. locals: also please add space between = and render

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab project)

      By Administrator on 2013-06-14T12:13:33 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling f7ea649f on dosire:scrum-view-for-milestone into 1b49ae2e on gitlabhq:master.

    By Administrator on 2013-06-14T12:33:27 (imported from GitLab project)

    By Administrator on 2013-06-14T12:33:27 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    thanks

    By Administrator on 2013-06-17T06:32:17 (imported from GitLab project)

    By Administrator on 2013-06-17T06:32:17 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    Thank you for the feedback!

    By Administrator on 2013-06-17T06:42:29 (imported from GitLab project)

    By Administrator on 2013-06-17T06:42:29 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: kirantpatil

    @dosire,

    How about supporting Huboard(Kanban board for github issues) "https://github.com/rauhryan/huboard" ?

    Huboard is built from the ground up using the GitHub public API.

    It is mentioned in http://feedback.gitlab.com/forums/176466-general/suggestions/3840944-kanban-planning-view-for-issues.

    By Administrator on 2013-06-17T08:28:30 (imported from GitLab project)

    By Administrator on 2013-06-17T08:28:30 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    @kirantpatil I'm all for someone making a Huboard fork as you can see at http://feedback.gitlab.com/forums/176466-general/suggestions/3890905-use-huboard-as-project-management-tool

    By Administrator on 2013-06-17T17:19:42 (imported from GitLab project)

    By Administrator on 2013-06-17T17:19:42 (imported from GitLab)

    • Please register or sign in to reply