Skip to content
Snippets Groups Projects

Add guidelines for the Contributing Process to CONTRIBUTING.md

Merged Add guidelines for the Contributing Process to CONTRIBUTING.md
contributing_guide into master
Merged gitlab-qa-bot requested to merge contributing_guide into master

Created by: jacobvosmaer

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 2fb5a08b1168df5b1ff4e0991cda3c5ff2b8ac91 on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T13:33:58 (imported from GitLab project)

    By Administrator on 2013-08-05T13:33:58 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 7abd9b7d2cab593005b32a4ecfff0659f3158fed on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T13:46:45 (imported from GitLab project)

    By Administrator on 2013-08-05T13:46:45 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacobvosmaer

    It took some doing but now the copy-paste responses should turn into proper markdown if you copy-paste them from the (default) Markdown view.

    By Administrator on 2013-08-05T14:31:40 (imported from GitLab project)

    By Administrator on 2013-08-05T14:31:40 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling ffa00959c231ac6b2dd4eb6e723e9ce56cae4d4d on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T14:52:56 (imported from GitLab project)

    By Administrator on 2013-08-05T14:52:56 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage increased (+0%) when pulling ffa00959c231ac6b2dd4eb6e723e9ce56cae4d4d on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T15:27:48 (imported from GitLab project)

    By Administrator on 2013-08-05T15:27:48 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling ffa00959c231ac6b2dd4eb6e723e9ce56cae4d4d on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T14:56:44 (imported from GitLab project)

    By Administrator on 2013-08-05T14:56:44 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling ffa00959c231ac6b2dd4eb6e723e9ce56cae4d4d on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-05T15:27:42 (imported from GitLab project)

    By Administrator on 2013-08-05T15:27:42 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    :thumbsup:

    By Administrator on 2013-08-06T06:31:26 (imported from GitLab project)

    By Administrator on 2013-08-06T06:31:26 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 53045a668bf006ce130a6b7ae6c4a4e40877509e on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-06T10:07:57 (imported from GitLab project)

    By Administrator on 2013-08-06T10:07:57 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
CONTRIBUTING.md
Unable to load the diff
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    This can be removed, they were closed and moved to the feedback application.

    (we do have some old ones open that Yves will handle)

    By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

    By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      I think this can be removed, it's a technicality to guarantee the next point:

      • Responds to issues and pull requests the issue team mentions them in

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      I think this is a technicality and can be removed.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      Closing an issue

      I don't like this generalized message. We should be specific when closing issues and not just reference a big document. Let's remove this answer.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      Same as above

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      Please resubmit your pull request following the

      Should be: "Please update your pull request according to". This emphasizes that you don't need to create a new pull request but rather have to update the existing one.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: senny

      Be as kind as possible to people trying to contribute

      I would reword it to: "Be kind to people trying to contribute"

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    • long lines are hard to review and result in hard to read diffs. I suggest we wrap the whole section to 80 chars.
    • The process is informative but not a required read if you want to contribute. As the CONTRIBUTING.md should be a required read before you jump in, we should keep it focused and on the point. We could create a PROCESS.md and link to it.

    I added a few comments, will take another look when wrapped to 80 chars and it's easier to read.

    By Administrator on 2013-08-06T11:38:39 (imported from GitLab project)

    By Administrator on 2013-08-06T11:38:39 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacobvosmaer

    @senny I hear you on the long lines. Unfortunately, if we start breaking them in this document then the line-breaks will transfer to wherever you copy-paste them. This is a feature of GitHub Flavored Markdown that I do not know how to circumvent. https://help.github.com/articles/github-flavored-markdown#newlines

    By Administrator on 2013-08-07T09:25:09 (imported from GitLab project)

    By Administrator on 2013-08-07T09:25:09 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 45876d7ab9b8c7a72e1a12f38f1c8b237894d679 on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-07T11:11:32 (imported from GitLab project)

    By Administrator on 2013-08-07T11:11:32 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dzaporozhets

    I agree with @senny about amount of text. I cant imagine someone read such long file. Lets keep it focused. Everything non-critical can be moved to external file

    By Administrator on 2013-08-07T11:27:18 (imported from GitLab project)

    By Administrator on 2013-08-07T11:27:18 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: jacobvosmaer

      I agree. If we say it should be avoided there is no need to make it easier with a copy-paste answer.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: jacobvosmaer

      I agree it is rather technical. Could this be phrased in terms of an intention @dosire?

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacobvosmaer

    I also agree on moving the process into a separate file. The information does not serve the need of a person wanting to open an issue or submit a pull request.

    I am holding off on pushing a commit splitting this off into PROCESS.md though because I would like to give @dosire the opportunity to respond to @senny's comments on the diff.

    By Administrator on 2013-08-07T15:26:35 (imported from GitLab project)

    By Administrator on 2013-08-07T15:26:35 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dosire

      I agree with Yves point, please remove.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dosire

      Please remove.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dosire

      I agree, please remove.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 348e9a74
    • CONTRIBUTING.md
    Unable to load the diff
    • gitlab-qa-bot
      gitlab-qa-bot @gitlab-qa-bot ·
      Author Owner

      Created by: dosire

      Same as above.

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab project)

      By Administrator on 2013-08-08T07:55:41 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    @jacobvosmaer @senny I agree with creating a PROCESS.md and linking to that. Thanks @senny for the suggestions.

    By Administrator on 2013-08-07T16:51:50 (imported from GitLab project)

    By Administrator on 2013-08-07T16:51:50 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacobvosmaer

    OK I have moved the guidelines into a separate file and addressed @senny's comments in the diff.

    By Administrator on 2013-08-08T07:29:17 (imported from GitLab project)

    By Administrator on 2013-08-08T07:29:17 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    :thumbsup: @senny what do you think?

    By Administrator on 2013-08-08T07:35:01 (imported from GitLab project)

    By Administrator on 2013-08-08T07:35:01 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 9f5952bbddf41417b5e2d709b5de3cbf1855d551 on contributing_guide into d602d5b1 on master.

    By Administrator on 2013-08-08T07:52:07 (imported from GitLab project)

    By Administrator on 2013-08-08T07:52:07 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: senny

    :thumbsup: we can improve it once it's merged.

    By Administrator on 2013-08-08T07:53:49 (imported from GitLab project)

    By Administrator on 2013-08-08T07:53:49 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jacobvosmaer

    I will squash and merge.

    By Administrator on 2013-08-08T07:54:15 (imported from GitLab project)

    By Administrator on 2013-08-08T07:54:15 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: dosire

    Whooo!

    By Administrator on 2013-08-08T07:57:32 (imported from GitLab project)

    By Administrator on 2013-08-08T07:57:32 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-0%) when pulling 348e9a74 on contributing_guide into 4e6f131c on master.

    By Administrator on 2013-08-08T08:15:02 (imported from GitLab project)

    By Administrator on 2013-08-08T08:15:02 (imported from GitLab)

    • Please register or sign in to reply