Improvements to English text
Created by: hencatsmith
Hi :)
I've spent a bit of time working on polishing some of the English text in GitLab. The quality is pretty admirable for the most part, but I definitely think I've been able to make a worthwhile amount of improvement.
I can reassure you that I haven't lazily cloned the repo, changed the strings, and sent an untested pull request. I took the time to get the dependencies and configuration in place and get bundle exec rails s running on localhost:3000 so that I could test each change properly.
Willing to work on this if there's anything you don't like, so let me know!
Merge request reports
Activity
3 3 %span.pull-right #{@issues.total_count} issues 4 4 5 5 %p.light 6 For all issues you should visit project issues page. Or you can use search panel to find specific issue 6 For all issues you should visit the project's issues page, or use the search panel to find a specific issue. Created by: karlhungus
Shouldn't this be: "For all issues you should visit the project's issues page, or use the search panel to find the specific issue."
By Administrator on 2013-08-15T19:08:25 (imported from GitLab project)
By Administrator on 2013-08-15T19:08:25 (imported from GitLab)
1 1 %h3.page-title My Projects 2 2 %p.light 3 All projects you have access to are listed here. Public projects are not included here unless you have membership in it 3 All projects you have access to are listed here. Public projects are not included here unless you are a member Created by: karlhungus
I'd suggest "Public projects are not included here unless you have membership in them" "Public projects are not included here unless you are a member"
Eh, I'm not sure about this one.
By Administrator on 2013-08-15T19:08:25 (imported from GitLab project)
By Administrator on 2013-08-15T19:08:25 (imported from GitLab)
6 6 %i.icon-plus 7 7 New Group 8 8 %p.light 9 Members of group have access to all group projects. 9 Group members have access to all a group's projects 1 1 %h3.page-title My Projects 2 2 %p.light 3 All projects you have access to are listed here. Public projects are not included here unless you have membership in it 3 All projects you have access to are listed here. Public projects are not included here unless you are a member 3 3 %span.pull-right #{@issues.total_count} issues 4 4 5 5 %p.light 6 For all issues you should visit project issues page. Or you can use search panel to find specific issue 6 For all issues you should visit the project's issues page, or use the search panel to find a specific issue. Created by: hencatsmith
I agree with joining the two sentences together. I disagree about using the definite article "the" to talk about an indefinite issue though.
By Administrator on 2013-08-15T19:09:56 (imported from GitLab project)
By Administrator on 2013-08-15T19:09:56 (imported from GitLab)
6 6 %i.icon-plus 7 7 New Group 8 8 %p.light 9 Members of group have access to all group projects. 9 Group members have access to all a group's projects Created by: hencatsmith
I'm afraid I disagree with you on this one (sorry!). The "of" after "all" is only grammatically necessary before certain pronouns in certain cases such as "all of us". Including it anywhere else is a stylistic preference that seems to vary by dialect.
By Administrator on 2013-08-15T19:35:13 (imported from GitLab project)
By Administrator on 2013-08-15T19:35:13 (imported from GitLab)
6 6 %i.icon-plus 7 7 New Group 8 8 %p.light 9 Members of group have access to all group projects. 9 Group members have access to all a group's projects 6 6 %i.icon-plus 7 7 New Group 8 8 %p.light 9 Members of group have access to all group projects. 9 Group members have access to all a group's projects Created by: karlhungus
Canadian here, might be influencing my choice, @stp-ip 's suggestion seems good to me
By Administrator on 2013-08-15T20:59:24 (imported from GitLab project)
By Administrator on 2013-08-15T20:59:24 (imported from GitLab)
Created by: hencatsmith
I'm happy for this to be merged now. I think @STP and @karlhungus are giving some good feedback about linguistic style, but I've found in the past that this process can drag on forever unless somebody says "stop". So I'd rather just forget about any more little tweaks and merge this as is, happy that all the changes bring a positive impact to GitLab.
By Administrator on 2013-08-16T07:49:43 (imported from GitLab project)
By Administrator on 2013-08-16T07:49:43 (imported from GitLab)
