Skip to content
Snippets Groups Projects

Fix the `service gitlab restart` command

Merged Fix the `service gitlab restart` command
fix_service_gitlab_restart into master
Merged gitlab-qa-bot requested to merge fix_service_gitlab_restart into master

Created by: jacobvosmaer

This commit addresses two related issues:

  • Sidekiq should shut down completely before we restart it;
  • If we restart unicorn with USR2 we need to kill the old master and worker processes.

/cc @randx @jaypea

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: MrKeiKun

    :thumbsup:

    webhooks <3

    By Administrator on 2013-08-23T08:45:30 (imported from GitLab project)

    By Administrator on 2013-08-23T08:45:30 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: coveralls

    Coverage Status

    Coverage decreased (-12.52%) when pulling 2b9d48cc on fix_service_gitlab_restart into 21e3d848 on master.

    By Administrator on 2013-08-23T08:54:09 (imported from GitLab project)

    By Administrator on 2013-08-23T08:54:09 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: jaypea

    thanks for fixing this.

    another issue is untouched by this is a call like service gitlab stop && service gitlab start this still would not work ;)

    By Administrator on 2013-08-23T08:52:31 (imported from GitLab project)

    By Administrator on 2013-08-23T08:52:31 (imported from GitLab)

  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot started a thread on commit 2b9d48cc
lib/support/init.d/gitlab
81 81 if [ "$PID" -ne 0 -a "$STATUS" -ne 0 ]; then
82 82 echo "Restarting $DESC..."
83 83 kill -USR2 `cat $WEB_SERVER_PID`
84 execute "mkdir -p $PID_PATH && $STOP_SIDEKIQ > /dev/null 2>&1 &"
84 execute "mkdir -p $PID_PATH && $STOP_SIDEKIQ > /dev/null 2>&1"
85 85 if [ `whoami` = root ]; then
86 86 execute "mkdir -p $PID_PATH && $START_SIDEKIQ > /dev/null 2>&1 &"
  • gitlab-qa-bot
    gitlab-qa-bot @gitlab-qa-bot ·
    Author Owner

    Created by: MrKeiKun

    can't sidekiq start without "&" ??

    By Administrator on 2013-08-23T09:01:40 (imported from GitLab project)

    By Administrator on 2013-08-23T09:01:40 (imported from GitLab)

Please register or sign in to reply