Skip to content
Snippets Groups Projects

Ssh key page improvements

Closed gitlab-qa-bot requested to merge github/fork/iamntz/ssh_key_page_improvements into master

Created by: iamntz

Every time i added a key i was annoyed by the fact i have to fill the title too.

So i wrote a small js snippet to extract the mail from the key itself.

It auto magically detects mail@domain and mail@domain.com.

PS: it seems the pull request also include files from my previous request (https://github.com/gitlabhq/gitlabhq/pull/488). I don't know how to separate those, sorry.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: superg2

    Oo, my message is related to the supression of the "remove short instructions..."

    By Administrator on 2012-03-01T14:18:55 (imported from GitLab project)

    By Administrator on 2012-03-01T14:18:55 (imported from GitLab)

  • Created by: dzaporozhets

    Team - it has some changes to layout that should not be merged.

    Please dont merge it. Leave it to me

    By Administrator on 2012-03-02T11:25:50 (imported from GitLab project)

    By Administrator on 2012-03-02T11:25:50 (imported from GitLab)

  • Created by: mikkyhouse

    -1. Having external links in application is a bad idea. We have wiki for this. And it breaks UI. We can use some code from this Pull Request but we wont accept it with all this staff. Sorry

    By Administrator on 2012-03-14T14:01:39 (imported from GitLab project)

    By Administrator on 2012-03-14T14:01:39 (imported from GitLab)

  • Created by: iamntz

    @mikkyhouse Actually this pull request was only an improvement of the ssh key form. But everything got messed up and i really hadn't time to clean the mess.

    The panel, on the other hand, is dedicated to new users, that doesn't know/what/care to use wiki from the github (i guess you are talking about this, right?) and is more like a help available anywhere :)

    But there is no problem with not including it, as I said in my initial post, was more like personal preference. I didn't wanted to be selfish :P

    By Administrator on 2012-03-14T18:24:58 (imported from GitLab project)

    By Administrator on 2012-03-14T18:24:58 (imported from GitLab)

  • Created by: dzaporozhets

    @iamntz If you can provide a Pull request with ssh key form only we'll be happy to include it

    By Administrator on 2012-03-14T19:15:26 (imported from GitLab project)

    By Administrator on 2012-03-14T19:15:26 (imported from GitLab)

  • Created by: iamntz

    Yeah, i have no idea how to isolate that! However, you can grab the code from here https://github.com/iamntz/gitlabhq/commit/cc4f9903ad08b0d41b76be2ae185467bb14ec675

    I don't care if i'll be on commiter list or not, so you can copy/paste. As long as the code is useful and used, i'm cool with that :)

    By Administrator on 2012-03-15T04:15:39 (imported from GitLab project)

    By Administrator on 2012-03-15T04:15:39 (imported from GitLab)

Please register or sign in to reply
Loading