Skip to content
Snippets Groups Projects

Standardize recently added commit diff api url

Merged gitlab-qa-bot requested to merge github/fork/alexvh/standardize_diff_api_url into master

Created by: alexvh

Use "/commits/:sha/diff" as opposed to "/commit/:sha", keeping in line with existing api urls (e.g. "/commits/:sha/blob", "/projects/:id", etc.)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: coveralls

    Coverage Status

    Coverage decreased (-0.18%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e8975207 on gitlabhq:master.

    By Administrator on 2013-08-26T16:49:23 (imported from GitLab project)

    By Administrator on 2013-08-26T16:49:23 (imported from GitLab)

  • Created by: coveralls

    Coverage Status

    Coverage decreased (-13.23%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e8975207 on gitlabhq:master.

    By Administrator on 2013-08-26T16:54:44 (imported from GitLab project)

    By Administrator on 2013-08-26T16:54:44 (imported from GitLab)

  • Created by: coveralls

    Coverage Status

    Coverage decreased (-13.17%) when pulling 499cb7e9e1f620ab2932bacb239f9e016b46aa70 on alexvh:standardize_diff_api_url into e8975207 on gitlabhq:master.

    By Administrator on 2013-08-26T16:58:08 (imported from GitLab project)

    By Administrator on 2013-08-26T16:58:08 (imported from GitLab)

  • Created by: dzaporozhets

    I think we better change /commits/:sha/blob to /blob/:sha

    By Administrator on 2013-08-26T17:13:15 (imported from GitLab project)

    By Administrator on 2013-08-26T17:13:15 (imported from GitLab)

  • Created by: alexvh

    I agree blob should be changed. How about I do the following?: [] Change blob to /blob (presumably, leaving existing path working as to not break existing users) [] Add a 'get /commits/:sha' for retrieving a commit's info (e.g. author, date, etc.) [*] Leave the commit diff api changed to '/commits/:sha/diff'

    By Administrator on 2013-08-26T17:40:25 (imported from GitLab project)

    By Administrator on 2013-08-26T17:40:25 (imported from GitLab)

  • Created by: dzaporozhets

    @alexvh +1 for this changes

    By Administrator on 2013-08-27T08:23:47 (imported from GitLab project)

    By Administrator on 2013-08-27T08:23:47 (imported from GitLab)

  • Created by: alexvh

    Updated. Commit message contains details of changes.

    By Administrator on 2013-08-28T01:26:30 (imported from GitLab project)

    By Administrator on 2013-08-28T01:26:30 (imported from GitLab)

  • Created by: coveralls

    Coverage Status

    Coverage remained the same when pulling 59f428dc on alexvh:standardize_diff_api_url into 777456b2 on gitlabhq:master.

    By Administrator on 2013-08-28T01:44:18 (imported from GitLab project)

    By Administrator on 2013-08-28T01:44:18 (imported from GitLab)

  • Created by: dzaporozhets

    Looks good. Thank you

    By Administrator on 2013-08-29T17:02:30 (imported from GitLab project)

    By Administrator on 2013-08-29T17:02:30 (imported from GitLab)

Please register or sign in to reply
Loading