Skip to content
Snippets Groups Projects

Add support to configure webhook_timeout in gitlab.yaml

Closed gitlab-qa-bot requested to merge github/fork/wesgurn/master into master

Created by: wesgurn

Our Gitlab instance needed the ability to increase the webhook_timeout used by HTTParty. It was hardcoded at 10 and I moved it to a gitlab.yaml file as a config variable

Webhook settings

webhook_timeout: 30 # default: 10 - Number of seconds to wait for HTTP response after sending webhook HTTP POST request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Unable to load the diff
  • Created by: MrKeiKun

    default is 10 but 30 is configured. Im confused...

    By Administrator on 2013-10-09T05:00:58 (imported from GitLab project)

    By Administrator on 2013-10-09T05:00:58 (imported from GitLab)

  • gitlab-qa-bot
  • Unable to load the diff
  • Created by: demisx

    Also, recommend sticking to best practices when titling your PRs. Use imperative style comments instead of past tense (see: http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD). For example, "Add support to ..." in lieu of "Added support to ..."

    By Administrator on 2013-09-02T16:23:16 (imported from GitLab project)

    By Administrator on 2013-09-02T16:23:16 (imported from GitLab)

  • Created by: wesgurn

    Good catch. I have updated the title to be in imperative style and thanks for the link!

    By Administrator on 2013-09-02T16:33:56 (imported from GitLab project)

    By Administrator on 2013-09-02T16:33:56 (imported from GitLab)

  • Created by: drakeguan

    Thumb up for this idea cause here we also faced to manipulate webhook's timeout by manually update /app/models/web_hook.rb. We thought it should not be the way to do that but that's what we have done right now.

    By Administrator on 2013-09-23T03:09:10 (imported from GitLab project)

    By Administrator on 2013-09-23T03:09:10 (imported from GitLab)

  • Created by: Razer6

    @wesgurn Can you please rebase because this is not mergeable.

    By Administrator on 2013-10-04T22:11:44 (imported from GitLab project)

    By Administrator on 2013-10-04T22:11:44 (imported from GitLab)

  • Created by: wesgurn

    Closing this. Will open a fresh rebase

    By Administrator on 2013-10-09T05:12:05 (imported from GitLab project)

    By Administrator on 2013-10-09T05:12:05 (imported from GitLab)

  • Created by: wesgurn

    I have rebased this in pull request #6971

    By Administrator on 2014-05-14T13:55:31 (imported from GitLab project)

    By Administrator on 2014-05-14T13:55:31 (imported from GitLab)

  • Created by: bassrock

    👍

    By Administrator on 2014-07-02T18:39:31 (imported from GitLab project)

    By Administrator on 2014-07-02T18:39:31 (imported from GitLab)

  • Please register or sign in to reply
    Loading