Skip to content
Snippets Groups Projects

Fix issue_closing_regex in gitlab.yml.example

Merged gitlab-qa-bot requested to merge github/fork/smashwilson/example-config-fix into master

Created by: smashwilson

It turns out that regex escapes and YAML quoted-scalar escapes don't play nicely together.

Before (with issue_closing_pattern uncommented):

smash@winter:config example-config-fix *$ irb -ryaml
2.0.0-p247 :001 > YAML.load_file('gitlab.yml.example')
Psych::SyntaxError: (gitlab.yml.example): found unknown escape character while parsing a quoted scalar at line 52 column 28

After:

smash@winter:config example-config-fix *$ irb -ryaml
2.0.0-p247 :001 > YAML.load_file('gitlab.yml.example')
 => {"production"=>{"gitlab"=>{"host"=>"localhost", "port"=>80, "https"=>false, "email_from"=>"gitlab@localhost", "support_email"=>"support@localhost", "default_projects_limit"=>10, "issue_closing_pattern"=>"^([Cc]loses|[Ff]ixes) +#\\d+", "default_projects_features"=>{"issues"=>true, "merge_requests"=>true, ...

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Created by: coveralls

    Coverage Status

    Coverage decreased (-20.84%) when pulling 8bbb5628 on smashwilson:example-config-fix into e0e88cdd on gitlabhq:master.

    By Administrator on 2013-09-15T20:23:22 (imported from GitLab project)

    By Administrator on 2013-09-15T20:23:22 (imported from GitLab)

  • Created by: Razer6

    This fixes #4919 (closed) @randx @dosire @jacobvosmaer This should definitely got into 6.1.

    By Administrator on 2013-09-15T20:32:00 (imported from GitLab project)

    By Administrator on 2013-09-15T20:32:00 (imported from GitLab)

  • Created by: dzaporozhets

    thank you

    By Administrator on 2013-09-16T06:05:52 (imported from GitLab project)

    By Administrator on 2013-09-16T06:05:52 (imported from GitLab)

Please register or sign in to reply
Loading